1889194 - Toolbar colors on Nightly are weird with the macOS Light theme and a dark desktop wallpaper

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

On my machine, the tabs toolbar is now relatively dark in macOS Light mode, both when the window is active and when it is inactive.
I'm on macOS 14.4, Nightly 20240402094108 (built from https://hg.mozilla.org/mozilla-central/rev/de086751acb845c252c37aab95a7e6b265df39a6 ), and I use the "Sonoma Horizon" wallpaper.

To match the native feel, the toolbar should be lighter when the window is active.

I'll add some screenshots which compare between Firefox and Activity Monitor.

Comment 1

[Markus Stange [:mstange]]

Attachment: Firefox active

Comment 2

[Markus Stange [:mstange]]

Attachment: Firefox inactive

Comment 3

[Markus Stange [:mstange]]

Attachment: Activity Monitor active

Comment 4

[Markus Stange [:mstange]]

Attachment: Activity Monitor inactive

Comment 5

[Markus Stange [:mstange]]

RGB values from Digital Color Meter:

	Firefox	Activity Monitor
Active Window	228	243
Inactive window	218	231

Comment 6

[Markus Stange [:mstange]]

Also, the main Firefox toolbar is always fully white. That also seems unexpected.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Ok, pretty sure this is a regression from bug 1886729... But, that said, if I back it out, I still don't get the right rgb values (thanks for the Digital Colour Meter tip, TIL!)

Comment 8

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1886729

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1889194 - Back out bug 1888706, instead not removing the separator in light mode. r=jules

The dark shade is more noticeable for some folks than others ;)

Instead, keep the nav-bar vs tabs separated by a thin border on Light
mode.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7eabbc68ff28
Back out bug 1888706, instead not removing the separator in light mode. r=desktop-theme-reviewers,dao

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7eabbc68ff28

Comment 12

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to replicate the issue on an affected Firefox Nightly 126.0a1 build from 2024-04-02, while following the steps described in Comment 0, under macOS 12.6.6.
Verified as fixed on Firefox RC 126.0-build 2, using macOS 12.6.6. The toolbar is now lighter when the window is active (similar to Activity Monitor).