1889229 - [rustc 1.78] error: associated function `from_wide_ptr_null` is never used

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Mike Hommey [:glandium]]

When building with rustc 1.78 beta 4, the following error is shown:

[task 2024-04-02T03:55:35.498Z] 03:55:35    ERROR -  error: associated function `from_wide_ptr_null` is never used
[task 2024-04-02T03:55:35.498Z] 03:55:35     INFO -    --> toolkit/components/bitsdownload/bits_client/bits/src/wide.rs:24:15
[task 2024-04-02T03:55:35.499Z] 03:55:35     INFO -     |
[task 2024-04-02T03:55:35.499Z] 03:55:35     INFO -  23 | pub trait FromWidePtrNull {
[task 2024-04-02T03:55:35.499Z] 03:55:35     INFO -     |           --------------- associated function in this trait
[task 2024-04-02T03:55:35.499Z] 03:55:35     INFO -  24 |     unsafe fn from_wide_ptr_null(wide: *const u16) -> Self;
[task 2024-04-02T03:55:35.500Z] 03:55:35     INFO -     |               ^^^^^^^^^^^^^^^^^^
[task 2024-04-02T03:55:35.500Z] 03:55:35     INFO -     |
[task 2024-04-02T03:55:35.500Z] 03:55:35     INFO -     = note: `-D dead-code` implied by `-D warnings`
[task 2024-04-02T03:55:35.500Z] 03:55:35     INFO -     = help: to override `-D warnings` add `#[allow(dead_code)]`
[task 2024-04-02T03:55:35.506Z] 03:55:35    ERROR -  error: could not compile `bits` (lib) due to 1 previous error

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1889229 - Remove unused FromWidePtrNull.

Comment 2

[Mike Hommey [:glandium]]

Also:

[task 2024-04-02T07:53:24.505Z] 07:53:24    ERROR -  error: the item `From` is imported redundantly
[task 2024-04-02T07:53:24.505Z] 07:53:24     INFO -    --> toolkit/components/bitsdownload/src/bits_interface/action.rs:14:5
[task 2024-04-02T07:53:24.505Z] 07:53:24     INFO -     |
[task 2024-04-02T07:53:24.505Z] 07:53:24     INFO -  14 | use std::convert::From;
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     |     ^^^^^^^^^^^^^^^^^^
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -    --> /rustc/805813650248c1a2f6f271460d728d1bb852d2a7\library\std\src\prelude\mod.rs:124:13
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     |
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     = note: the item `From` is already defined here
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     |
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     = note: `-D unused-imports` implied by `-D warnings`
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     = help: to override `-D warnings` add `#[allow(unused_imports)]`
[task 2024-04-02T07:53:24.507Z] 07:53:24    ERROR -  error: the item `From` is imported redundantly
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -    --> toolkit/components/bitsdownload/src/bits_interface/error.rs:16:5
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     |
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -  16 | use std::convert::From;
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     |     ^^^^^^^^^^^^^^^^^^
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -    --> /rustc/805813650248c1a2f6f271460d728d1bb852d2a7\library\std\src\prelude\mod.rs:124:13
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     |
[task 2024-04-02T07:53:24.507Z] 07:53:24     INFO -     = note: the item `From` is already defined here
[task 2024-04-02T07:53:24.507Z] 07:53:24    ERROR -  error: could not compile `bitsdownload` (lib) due to 2 previous errors

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1889229 - Remove redundant imports from bitdownload.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c59beba199d
Remove unused FromWidePtrNull. r=application-update-reviewers,bytesized
https://hg.mozilla.org/integration/autoland/rev/de8a5d43ace1
Remove redundant imports from bitdownload. r=application-update-reviewers,bytesized

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/8c59beba199d
https://hg.mozilla.org/mozilla-central/rev/de8a5d43ace1