188925 - Remove comment about NS_ASSERTION being deprecated

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[John Keiser (jkeiser)]

bsmedberg points out these comments that show NS_ASSERTION as being deprecated:

http://lxr.mozilla.org/seamonkey/source/xpcom/glue/nsDebug.h#206

These are *so* not deprecated, or if they are supposed to be, someone needs to
inform every active dev on Mozilla.  NS_WARNING and NS_PRE/POSTCONDITION are
other macros that are used under this banner of deprecation.

Comment 1

[Boris Zbarsky [:bzbarsky]]

As a note, NS_ABORT_IF_FALSE and NS_ASSERTION differ in one important regard --
NS_ABORT_IF_FALSE, in debug build, _will_ terminate execution of the program
when it triggers.  Given how many bogus asserts we have, replacing one with the
other would be ... difficult.

Comment 2

[Boris Zbarsky [:bzbarsky]]

er, comment 1 applies to Linux.  On the mac, the program is not terminated; not
sure about windows.

Comment 3

[Doug Turner (:dougt)]

yup.  done. 

Checking in nsDebug.h;
/cvsroot/mozilla/xpcom/glue/nsDebug.h,v  <--  nsDebug.h
new revision: 1.10; previous revision: 1.9
done