1889254 - [rustc 1.78] lld-link: error: undefined symbol: __declspec(dllimport) WakeByAddressSingle

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Building with rustc 1.78 beta 4 fails with the following error:

[task 2024-04-02T22:24:09.811Z] 22:24:09    ERROR -  lld-link: error: undefined symbol: __declspec(dllimport) WakeByAddressSingle
[task 2024-04-02T22:24:09.811Z] 22:24:09     INFO -  >>> referenced by /rustc/805813650248c1a2f6f271460d728d1bb852d2a7\library\std\src\sync\mpmc\waker.rs:190
[task 2024-04-02T22:24:09.811Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(std::sync::mpmc::waker::SyncWaker::disconnect::h50cd9905486e7d81)
[task 2024-04-02T22:24:09.811Z] 22:24:09     INFO -  >>> referenced by /rustc/805813650248c1a2f6f271460d728d1bb852d2a7\library\std\src\sync\mpmc\waker.rs:190
[task 2024-04-02T22:24:09.812Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(std::sync::mpmc::waker::SyncWaker::disconnect::h50cd9905486e7d81)
[task 2024-04-02T22:24:09.812Z] 22:24:09     INFO -  >>> referenced by /rustc/805813650248c1a2f6f271460d728d1bb852d2a7\library\std\src\sync\mpmc\waker.rs:193
[task 2024-04-02T22:24:09.812Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(std::sync::mpmc::waker::SyncWaker::disconnect::h50cd9905486e7d81)
[task 2024-04-02T22:24:09.812Z] 22:24:09     INFO -  >>> referenced 963 more times
[task 2024-04-02T22:24:09.812Z] 22:24:09    ERROR -  lld-link: error: undefined symbol: __declspec(dllimport) WakeByAddressAll
[task 2024-04-02T22:24:09.812Z] 22:24:09     INFO -  >>> referenced by /builds/worker/checkouts/gecko/third_party/rust/authenticator/src/statecallback.rs:44
[task 2024-04-02T22:24:09.812Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(authenticator::statecallback::StateCallback$LT$T$GT$::call::h3459b7fb6c43756b)
[task 2024-04-02T22:24:09.813Z] 22:24:09     INFO -  >>> referenced by /builds/worker/checkouts/gecko/third_party/rust/authenticator/src/statecallback.rs:44
[task 2024-04-02T22:24:09.813Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(authenticator::statecallback::StateCallback$LT$T$GT$::call::h3d11ca4b9b6e4799)
[task 2024-04-02T22:24:09.813Z] 22:24:09     INFO -  >>> referenced by /builds/worker/checkouts/gecko/third_party/rust/authenticator/src/statecallback.rs:44
[task 2024-04-02T22:24:09.813Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(authenticator::statecallback::StateCallback$LT$T$GT$::call::h52c833e8a8ff1808)
[task 2024-04-02T22:24:09.813Z] 22:24:09     INFO -  >>> referenced 24 more times
[task 2024-04-02T22:24:09.813Z] 22:24:09    ERROR -  lld-link: error: undefined symbol: __declspec(dllimport) WaitOnAddress
[task 2024-04-02T22:24:09.814Z] 22:24:09     INFO -  >>> referenced by /builds/worker/checkouts/gecko/toolkit/components/bitsdownload/src/bits_interface/monitor.rs:96
[task 2024-04-02T22:24:09.814Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(bitsdownload::bits_interface::monitor::MonitorRunnable::allocate::Run::hef36d193b269229c)
[task 2024-04-02T22:24:09.814Z] 22:24:09     INFO -  >>> referenced by /builds/worker/checkouts/gecko/security/manager/ssl/data_storage/src/lib.rs:796
[task 2024-04-02T22:24:09.814Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(data_storage::DataStorage::wait_for_ready::he81450d54494f56e)
[task 2024-04-02T22:24:09.814Z] 22:24:09     INFO -  >>> referenced by /builds/worker/checkouts/gecko/servo/components/style/driver.rs:126
[task 2024-04-02T22:24:09.814Z] 22:24:09     INFO -  >>>               gkrust.lib(gkrust-3f48253b5b7b46f3.gkrust.e6343b24f9267d63-cgu.0.rcgu.o):(style::driver::traverse_dom::h0ff62a9ff70efadf)
[task 2024-04-02T22:24:09.814Z] 22:24:09     INFO -  >>> referenced 14 more times
[task 2024-04-02T22:24:09.815Z] 22:24:09    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:541: xul.dll] Error 1

(and in more directories)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1889254 - Link synchronization where needed.

rust 1.78's libstd adds a dependency on synchronization on Windows.

This is similar to what was done in bug 1736486 for bcrypt.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08ea8edc42ee
Link synchronization where needed. r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/08ea8edc42ee