188931 - [FIX]right-align 'Helper Application textbox

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Jo Hermans]

build 2003011303 on Mac OS 9.2.2

Since bug 86640 is fixed (hurray !), I noticed that the filename of the helper
application is left aligned in the textbox. In my case, it was
"Honey:Applications (Mac OS 9):Internet Utilities:Aladdin Folder:StuffIt
Expander™ 5.5:StuffIt Expander™" which (obviously) didn't fit in the box.

I'm filing this under platform All/All, because the bug should exists on all
platforms. Macs might be more vulnearable, becuase pathnames tend to be much
larger than on other platforms. Believe it or not, but the above pathname is the
*default* one under Mac OS 9.2.2. Only the 'Honey' part was variable, because
it's the name of my system disk. And this one isn't even considered a 'long
filename' (with foldernames > 32 chars), you need Mac OS X for that.

Can we right align this textbox ? Or print it as "Honey:...:StuffIt Expander™",
but that might be too difficult, since it has to expand back to the full length
when you start to edit.

Comment 1

[Boris Zbarsky [:bzbarsky]]

well, on the mac editing should not be a concern -- it should be disabled....

We could certainly try a different alignment for the textbox.  pkw, interested?
 Or should I find someone else?

Comment 2

[Jo Hermans]

Actually I was able to edit the path directly, without using the 'Choose'
button. A bit unusual on a Mac, but since we're dropping support for Mac OS 9
soon ... (and pathnames are used on Mac OS X).

Comment 3

[Boris Zbarsky [:bzbarsky]]

That's a bug. We have code that specifically disables that input field on a
mac... but it's incorrectly placed, now that I look at it.  Please file a
separate bug on that? (just assign it to me, please)

Comment 4

[Jo Hermans]

that is bug 188949

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: patch

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: same as -w

Comment 7

[Boris Zbarsky [:bzbarsky]]

taking

Comment 8

[Boris Zbarsky [:bzbarsky]]

+         this.mIsMac = (this.mDialog.navigator.platform.indexOf( "Mac" ) != -1)
|| 1;

The || 1 was part of me testing; I will not be checking that part in.  ;)

Comment 9

[Philip K. Warren]

Comment on attachment 111454 [details] [diff] [review]
same as -w

>+        var useDefault;
>         if (this.mLauncher.MIMEInfo.preferredAction == this.nsIMIMEInfo.useSystemDefault) {
>             // Open (using system default).
>-            var useDefault = this.dialogElement( "useSystemDefault" );
>+            useDefault = this.dialogElement( "useSystemDefault" );
.....
>             // Disable that choice.
>-            var useDefault = this.dialogElement( "useSystemDefault" );
>+            useDefault = this.dialogElement( "useSystemDefault" );

Why not set useDefault = this.dialogElement( ... ) once?

Fix that and r=pkw.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: patch updated to review comments (and without the || 1)

Comment 11

[Boris Zbarsky [:bzbarsky]]

fixed.

Comment 12

[Chris Petersen]

Verified in the 2003-01-15-08 trunk under 10.2.3.