1889310 - [wpt-sync] Sync PR 45487 - Reland "Add WPT for Compression Dictionary Transport"

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45487 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45487
Details from upstream follow.

Tsuyoshi Horo <[e-mail]> wrote:

Reland "Add WPT for Compression Dictionary Transport"

This reverts commit f27cfea7c57868b51731c9e5d1316f2c952de944.

Reason for revert: Relanding dictionary-fetch-with-link-* tests.

dictionary-fetch-with-link-* tests are testing the behaviour of fetching
a dictionary using link elements or link HTTP header.
Fetching a dictionary is internally using requestIdleCallback in
blink::PreloadHelper::FetchDictionaryIfNeeded(). But requestIdleCallback
doesn't work correctly in the single-threaded compositor mode.
So this CL updates VirtualTestSuites for these tests to skip that mode
but expect to pass for virtual/threaded.

Also this CL make tests wait for a while with requestIdleCallback() to
ensure that the dictionary is fetched.

Original change's description:

Revert "Add WPT for Compression Dictionary Transport"

This partially reverts commit f8d14034be021f773bfd4244061f9d3f06915d80.

Reason for revert: dictionary-fetch-with-link-* tests are flaky.
First failing run
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/119589/blamelist

Original change's description:

Add WPT for Compression Dictionary Transport

Bug: 1413922
Change-Id: I4f7aad71a043354f5c107a301b66d58a1409ef89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5401505
Commit-Queue: Tsuyoshi Horo \<[e-mail]>
Reviewed-by: Patrick Meenan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1281548}

Bug: 1413922
Change-Id: If52e3f9074e51265da65fef08456fc1d42be735a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5418514
Reviewed-by: Fergal Daly \<[e-mail]>
Commit-Queue: Tsuyoshi Horo \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1281675}

Bug: 1413922
Change-Id: Ie0ac767ff7626c6e2b2811e8631823204a590f8b

Reviewed-on: https://chromium-review.googlesource.com/5417959
WPT-Export-Revision: abe8643b22f2a44b9ab179f88088565f98fa66ff

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b3b57f54610dd73687fc52d9ea7f205b0ce4a59

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL : 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 4[GitHub]
ERROR: 2

Chrome

OK : 2
FAIL : 4

Safari

OK : 2
FAIL : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fetch/compression-dictionary/dictionary-fetch-with-link-element.tentative.https.html [wpt.fyi]: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], OK [GitHub] (Chrome: OK, Safari: OK)
  • Browser supports link element with dictionary rel.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Fetch same origin dictionary using link element: FAIL (Chrome: FAIL, Safari: FAIL)
  • Fetch cross origin dictionary using link element: FAIL (Chrome: FAIL, Safari: FAIL)
• /fetch/compression-dictionary/dictionary-fetch-with-link-header.tentative.https.html [wpt.fyi]: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], OK [GitHub] (Chrome: OK, Safari: OK)
  • Fetch same origin dictionary using link header: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f394f5b10ba
[wpt PR 45487] - Reland "Add WPT for Compression Dictionary Transport", a=testonly
https://hg.mozilla.org/integration/autoland/rev/1500ac770169
[wpt PR 45487] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0f394f5b10ba
https://hg.mozilla.org/mozilla-central/rev/1500ac770169