188940 - need folder pane icon for junk folder [classic and modern]

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

need folder pane icon for junk folder [classic and modern]

(Assuming jglick wants us to have a special icon for the junk folder)

Comment 1

[Lori Kaplan]

plussing for buffy. 

Comment 2

[(not reading, please use [e-mail] instead)]

note, I've checked in some place holder icons until we have real icons.

Comment 3

[gail]

Seth, I noticed you are using placeholders for open and closed. Do you need me
to create both?

Comment 4

[jglick]

I didn't think we were using open versions of folder pane folders.

Comment 5

[gail]

Image sent to Seth. If it turns out you need another state, file a new bug on me
and I will take care of it. 

Comment 6

[gail]

reassigning to Seth.

Comment 7

[Quinn Yost (mythdraug)]

*** Bug 189535 has been marked as a duplicate of this bug. ***

Comment 8

[(not reading, please use [e-mail] instead)]

I've landed the folder pane icon from gail.

both classic and modern are using the same icon.

Comment 9

[jglick]

Seth, Gail is going to send you a new icon for the folder pane for Modern.

Junk Mail folder pane icon for Modern should either be the same icon as used for
the Thread Pane column and header (seth's original placeholder) OR a similar
icon with a folder behind it (gail to create).

Comment 10

[(not reading, please use [e-mail] instead)]

> I didn't think we were using open versions of folder pane folders.

we are, see the file menu flyout, when a folder has a subfolder.

I've landed new modern, folder pane icons from gail.

http://lxr.mozilla.org/seamonkey/source/themes/classic/messenger/icons/folder-junk-open.gif
http://lxr.mozilla.org/seamonkey/source/themes/classic/messenger/icons/folder-junk.gif
(note the two for classic are the same icon.  this should be spun out to a new bug.)

http://lxr.mozilla.org/seamonkey/source/themes/modern/messenger/icons/folder-junk-open.gif
http://lxr.mozilla.org/seamonkey/source/themes/modern/messenger/icons/folder-junk.gif
(these are different.)

marking fixed.

Comment 11

[Peter Lairo]

Artistic nits: 

The modern icons both look like unrecognizable blobs. Suggest to move the trash
can to the right, so it extends slightly beyond the right edge of the folder.
Somehow, both the folder and the trash can must become recognizable as such.

The classic icon is a "recycling" bin! "Recycle" means to "reuse". I don't think
there should be an association between "junk mail" and "reuse". :-\ I do like
the bold color though.

Suggest to reopen this bug until the icons have a higher level of quality. (sorry)

Comment 12

[esther]

Using trunk build 20030205 on winxp, maco osx and linux the icons for the Junk
folder are correct in both Classic and Modern theme according to spec. 
Verifying this as fixed.  Maybe we should log a new bug for the better quality
of icon.

Comment 13

[esther]

verifying