Closed Bug 1889400 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 45501 - Move the test name computation out of _generate_test

Categories

(Core :: Graphics: Canvas2D, task, P4)

Product:
Core
Component:
Graphics: Canvas2D
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45501 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45501
Details from upstream follow.

Jean-Philippe Gravel <jpgravel@chromium.org> wrote:

Move the test name computation out of _generate_test

The test name is now computed in _finalize_params. This gives better
separation of concerns: it was not _generate_test's job to configure
the test parameters. More will be moved to _finalize_params in
follow-up CLs.

Bug: 330885075
Change-Id: I525b60231c113b5eaaeaf899f6412e63749e159d

Reviewed-on: https://chromium-review.googlesource.com/5378645
WPT-Export-Revision: c644194f19dd7956eb9df99931b78bdc81912efc

Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e15c708a41e2 [wpt PR 45501] - Move the test name computation out of _generate_test, a=testonly
Test result changes from PR not available.
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/e15c708a41e2

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.