Closed Bug 1889481 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 45514 - == to ===, != to !==

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox126 fixed)

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(7 files)

Notable wpt changes
112.30 KB, text/plain
Details
Notable wpt changes
112.30 KB, text/plain
Details
Notable wpt changes
112.30 KB, text/plain
Details
Notable wpt changes
112.30 KB, text/plain
Details
Notable wpt changes
112.30 KB, text/plain
Details
Notable wpt changes
112.30 KB, text/plain
Details
Notable wpt changes
112.30 KB, text/plain
Details

Sync web-platform-tests PR 45514 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45514
Details from upstream follow.

Caleb Raitto <caraitto@chromium.org> wrote:

== to ===, != to !==

These are preferred as they're more strict [0][1].

The exception is comparisons with null -- we sometimes want
== and != since they also match undefined.

[0] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_equality

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_inequality

Change-Id: I7a391faab107f02c2486cdd59ebb415c7613526d

Reviewed-on: https://chromium-review.googlesource.com/5420989
WPT-Export-Revision: 0a6288f9afda94fea4b472c5ca2d48455978aefb

PR 45514 applied with additional changes from upstream: 58d4f936dfa97887302643ba1669d787c50b76fa
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 138 tests and 2 subtests ## Status Summary ### Firefox `OK` : 133[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 135[GitHub] `FAIL` : 645[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 656[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 133 `PASS` : 213 `FAIL` : 444 `ERROR` : 3 ### Safari `OK` : 135 `FAIL` : 656 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d6a25828df156998abc4fc07a63ff8166d407b) [GitHub PR Head](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 138 tests and 2 subtests ## Status Summary ### Firefox `OK` : 133[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 135[GitHub] `FAIL` : 645[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 656[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 133 `PASS` : 213 `FAIL` : 444 `ERROR` : 3 ### Safari `OK` : 135 `FAIL` : 656 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d6a25828df156998abc4fc07a63ff8166d407b) [GitHub PR Head](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 138 tests and 2 subtests ## Status Summary ### Firefox `OK` : 133[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 135[GitHub] `FAIL` : 645[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 656[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 133 `PASS` : 213 `FAIL` : 444 `ERROR` : 3 ### Safari `OK` : 135 `FAIL` : 656 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d6a25828df156998abc4fc07a63ff8166d407b) [GitHub PR Head](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 138 tests and 2 subtests ## Status Summary ### Firefox `OK` : 133[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 135[GitHub] `FAIL` : 645[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 656[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 133 `PASS` : 213 `FAIL` : 444 `ERROR` : 3 ### Safari `OK` : 135 `FAIL` : 656 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d6a25828df156998abc4fc07a63ff8166d407b) [GitHub PR Head](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 138 tests and 2 subtests ## Status Summary ### Firefox `OK` : 133[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 135[GitHub] `FAIL` : 645[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 656[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 133 `PASS` : 213 `FAIL` : 444 `ERROR` : 3 ### Safari `OK` : 135 `FAIL` : 656 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d6a25828df156998abc4fc07a63ff8166d407b) [GitHub PR Head](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce763fb8a29e [wpt PR 45514] - == to ===, != to !==, a=testonly
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 138 tests and 2 subtests ## Status Summary ### Firefox `OK` : 133[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 135[GitHub] `FAIL` : 645[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 656[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 133 `PASS` : 213 `FAIL` : 444 `ERROR` : 3 ### Safari `OK` : 135 `FAIL` : 656 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d6a25828df156998abc4fc07a63ff8166d407b) [GitHub PR Head](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_base) ## Details (See attachment for full changes)
Test result changes from PR not available.
Attached file Notable wpt changes —
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 138 tests and 2 subtests ## Status Summary ### Firefox `OK` : 133[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 135[GitHub] `FAIL` : 645[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 656[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 133 `PASS` : 213 `FAIL` : 444 `ERROR` : 3 ### Safari `OK` : 135 `FAIL` : 656 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d6a25828df156998abc4fc07a63ff8166d407b) [GitHub PR Head](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=e1cb90faa517f057ebef4fd988679988101bbf71&label=pr_base) ## Details (See attachment for full changes)
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/ce763fb8a29e

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: