1889564 - Some queryParams are not being properly removed from Amazon

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Ciprian Georgiu, Desktop QA]

Found in

• latest Nightly 126.0a1

Affected versions

• latest Nightly 126.0a1

Tested platforms

• Affected platforms: Win 11, macOS 13 and Ubuntu 22.04

Preconditions

• Standard setttings is applied in about:preferences#security
• Set “privacy.query_stripping.enabled” to false in about:config.

Steps to reproduce

1. Navigate to https://www.amazon.com/Vintage-Football-Cards-Sealed-Packs/dp/B00CFXUAIW/ref=pd_rhf_dp_s_pd_crcbs_d_sccl_2_5/145-5837245-3754957?creativeASIN=lyp2Z&content-id=amzn1.sym.31346ea4-6dbc-4ac4-b4f3-cbf5f8cab4b9&pf_rd_p=31346ea4-6dbc-4ac4-b4f3-cbf5f8cab4b9&pf_rd_r=BB0GMCH77X7RSH3HY706&pd_rd_wg=XZ0x3&pd_rd_r=8e217f12-6a90-41b4-b827-71067fcc4ab0&pd_rd_i=B00CFXUAIW&psc=1
2. Right click on the link, then click on "Copy Without Site Tracking"
3. Open another tab and paste the copied linked into the URL bar.

Expected result

• The query parameter creativeASIN is correctly stripped from the URL, as per https://phabricator.services.mozilla.com/D203080

Actual result

• The query parameter is not stripped from the URL.

Regression range

• This is not a regression. It can also be reproduced with Nightly builds after the extened list of parameters was added.

Additional notes

• Other querry parameters that are not correctly stripped from amazon:
  field-lbr_brands_browse-bin - https://www.amazon.com/stores/node/20648519011?channel=discovbar?field-lbr_brands_browse-bin=AmazonBasics&ref_=nav_cs_amazonbasics
  initialIssue, - www.amazon.com/b/ref=s9_acss_bw_cg_FNNAV_2b1_w?node=3733491&initialIssue=ATVPDKIKX0DER&pf_rd_s=merchandised-search-4&pf_rd_r=3DV9NVHJNSSFV26RFWK7&pf_rd_t=101&pf_rd_p=28c842bb-1445-4c5c-9013-6b51e3fdd911&pf_rd_i=1063306
  linkId - https://www.amazon.com/b/ref=s9_acss_bw_cg_FNNAV_2c1_w?node=680098011&linkId=ATVPDKIKX0DER&pf_rd_s=merchandised-search-4&pf_rd_r=3DV9NVHJNSSFV26RFWK7&pf_rd_t=101&pf_rd_p=28c842bb-1445-4c5c-9013-6b51e3fdd911&pf_rd_i=1063306
  linkCode - https://www.amazon.com/b/ref=s9_acss_bw_cg_FNNAV_2b1_w?node=3733491&linkCODE=ATVPDKIKX0DER&pf_rd_s=merchandised-search-4&pf_rd_r=3DV9NVHJNSSFV26RFWK7&pf_rd_t=101&pf_rd_p=28c842bb-1445-4c5c-9013-6b51e3fdd911&pf_rd_i=10633066
  refRID - https://www.amazon.com/gp/bestsellers/?refRID=nav_em_cs_bestsellers_0_1_1_2
  visitId - https://www.amazon.com/b/ref=s9_acss_bw_cg_FNNAV_5a1_w?node=3733651&visitId=ATVPDKIKX0DER&pf_rd_s=merchandised-search-4&pf_rd_r=3DV9NVHJNSSFV26RFWK7&pf_rd_t=101&pf_rd_p=28c842bb-1445-4c5c-9013-6b51e3fdd911&pf_rd_i=1063306
  spIA - https://www.amazon.com/b/ref=s9_acss_bw_cg_FNNAV_5b1_w?node=3734121&spIA=ATVPDKIKX0DER&pf_rd_s=merchandised-search-4&pf_rd_r=3DV9NVHJNSSFV26RFWK7&pf_rd_t=101&pf_rd_p=28c842bb-1445-4c5c-9013-6b51e3fdd911&pf_rd_i=10633066

Comment 1

[Abhishek Madan[:abhishekmadan]]

Attachment: Bug 1889564 - All params for Strip on Share are converted to lowercase before the comparison check.r=pbz

Comment 3

[Abhishek Madan[:abhishekmadan]]

Attachment: Bug 1889564 - Removed capitalizations from parameters and added domains to strip on share list.r=pbz

Comment 17

[Abhishek Madan[:abhishekmadan]]

Attachment: Bug 1889564 - Lowercase strip on share list during import .r=pbz.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b24891ce2a9
Lowercase strip on share list during import .r=pbz,anti-tracking-reviewers.

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6b24891ce2a9

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:abhishekmadan, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.

Comment 21

[Liz Henry (:lizzard)]

Donal, is this something you might want in a planned 126 dot release? Given the number of duplicate bug reports, it might be a good candidate.
I will leave it to you whether you want to change the 126 wontfix status or not.

Comment 22

[Donal Meehan [:dmeehan]]

I'm ok with leaving this as wontfix, the duplicates are all from internal QA testing.

Comment 23

[Ciprian Georgiu, Desktop QA]

Abhishek, I've verified this bug and it seems that the querry parameters are now properly deleted with latest Beta 127.0b1 on macOS 13. However there's one exception, field-lbr_brands_browse-bin. This tracking query parameter is still not stripped from this link - https://www.amazon.com/stores/node/20648519011?channel=discovbar?field-lbr_brands_browse-bin=AmazonBasics&ref_=nav_cs_amazonbasics.

Can you please take a look at this?

Comment 24

[Abhishek Madan[:abhishekmadan]]

Hi, in this case field-lbr_brands_browse-bin is not a query parameter itself but its in the value of a query parameter. So it should not be removed

Comment 25

[Ciprian Georgiu, Desktop QA]

Thank you for clarifying! I'll mark the bug as verified fixed since the query parameters are correctly stripped from both this bug and its duplicates.