1889646 - Menus and panels remain opened when hovering and clicking on tabs after the tab preview is displayed

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Gif showing the issue

Found in

• Latest Nightly 126.0a1

Affected versions

• Latest Nightly 126.0a1

Tested platforms

• Affected platforms: Windows 10, Windows 11, macOS 13 and Ubuntu 22.04
• Unaffected platforms: none

Preconditions

• Have browser.tabs.cardPreview.enabled set to true

Steps to reproduce

1. Open a few tabs
2. Click on menu, for example Hamburger Menu or Download panel.
3. Hover over a tab
4. Without leaving the tab strip click on all the tabs

Expected result

• The opened menu is closed when clicking a tab OR tab preview is not shown when the menu is opened, just as it does when a context menu is opened (only on Mac).

Actual result

• Menus, panels will not close if preview is visible and clicking on different tabs without leaving the tabstrip.

Regression range

• Not a regression since this is also reproducible on old Nightly build from 2024-01-14 where this feature officially landed in Nightly.

Additional notes

• On Chrome if I have their hamburger menu open or context menu I can't use the tab preview, but on some menus like Bookmark or Users I can though it will close immediately when clicking on a tab.

Comment 1

[Jeremy Swinarton]

I have a proof-of-concept solution that addresses this bug, but implementing the fix as described leads to some inconsistent UI behaviour that I need additional direction on to proceed.

My implementation disables the tab preview in the event that another popover is active. However, all other tab interactivity still fires -- for example, hovering over the close button reveals the hover style and the tooltip appears. This means it is very close to the original, non-tab-preview behaviour, with the exception that the original tooltip does not appear. This seems inconsistent and could be interpreted as a bug by an end user in my opinion. I see two ways of fixing this:

1. If a popup is active, revert to the original non-tab-preview behaviour, complete with all tooltips.
2. If a popup is active, completely disable interactivity in the browser until the popup disappears. This is what happens on MacOS if a context menu is active, i.e. it is not just the tab preview that is not visible, but everything -- no button hover states are shown, and all interactivity in the content area is disabled until the context menu disappears.

Comment 2

[Jeremy Swinarton]

Attachment: WIP: Bug 1889646: disable tab preview when menus or panels are opened

Comment 3

[Chris Peterson [:cpeterson]]

This bug is a THP release blocker.

Comment 4

[Jeremy Swinarton]

Attachment: Phabricator revision

Comment 5

[Jeremy Swinarton]

Just flagging that this should be closed by the same fix that addressed bug1878051.

Comment 6

[Bogdan Maris, Desktop Test Engineering]

(In reply to Jeremy Swinarton from comment #5)

Just flagging that this should be closed by the same fix that addressed bug1878051.

Indeed, I'm going to close it as resolved fixed based on this. I also followed the steps here and the preview is not opened anymore if a panel/menu is opened and the panel/menu will close if clicking on tabs.