1889756 - [toolbar redesign] Create ToolbarTelemetryMiddleware for toolbar telemetry

Status: RESOLVED WONTFIX

(Firefox for Android :: Experimentation and Telemetry, task, P3)

Description

[Roger Yang [:royang]]

This is a follow up for this comment

Ideally, these should be living in a metrics or telemetry middleware (or in the interactor/controller if there isn't a Store) rather than a lambda in the UI code. This is so:

• The Compose code is only handling UI logic and dispatches Actions and doesn't care about what happens after.
• The metrics can be covered with tests.
• The previews (where applicable) aren't broken.

Long term, we probably want to shoot for having a ToolbarStore with a ToolbarTelemetryMiddleware and ToolbarNavigationMiddleware which handles some of these very complex lambdas in the Compose code:

Comment 1

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's follow-up work to priority P3 until we finish fixing our Release blockers.