Closed Bug 188978 Opened 22 years ago Closed 15 years ago

Regression: Modern no longer uses dots for its resizer grippy in windows luna theme

Categories

(SeaMonkey :: Themes, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED EXPIRED

People

(Reporter: bruppel1, Unassigned)

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030113 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030113 This seems to be a direct result of the fix for Bug 184169. The modern theme in windows xp using the luna theme (the bubbly one instead of the classic grey one) used to use dots for its resizer. However, when using modern theme with the windows classic theme, there was a color mismatch. In fixing that color mismatch, the code that would paint the modern theme in luna with the dots was changed, and instead we now have lines instead of dots. It was possible to have modern paint the dotted resizer when in luna, and the lined resizer in windows classic. It should still be possible. If one would argue that modern should not try to heed the winxp theme because it is its own independent theme, consider this: By using the lined resizer only, modern is adhering to an ancient OS theme rather than a modern theme (luna). Either way, modern is adhering to an established theme. One of these two ways is easier to laugh at. Reproducible: Always Steps to Reproduce: 1.Switch windows XP to the luna theme (the one that is blue or silver and not flat gray) 2.Switch mozilla to modern theme 3.open a navigator window Actual Results: The resizer widget, drawn in the lower right corner, uses diagonal lines. Before January 5 it used dots, which match the more "modern" luna theme. Expected Results: Mozilla should display the resizer dots when using luna in winxp.
Just to clarify. The problem used to be that we asked the OS to paint the resizer. In all Mozilla themes. It just so happens that Luna and Modern do not clash too badly color-wise. Other XP visual styles _do_ clash with Modern, which is how the problem got noticed. Needless to say, Luna clashes with Toy Factory and Orbit and so forth. Since Modern is platform-independent and looks identical on all of XP, Win2k, NT, 95/98/ME, MacOS, Linux, etc, it makes sense to use the resizer look that most people would recognize as a resizer. This is _not_ the Luna look but the Windows Classic look (which looks the same as the MacOS resizer, I must note... thus making it even more recognizable as a resizer). All this has been hashed over already in bug 184169; please make sure to read that bug before commenting on this one.
Okay, it looks like you are saying that what I was seeing WAS a native UI widget from winxp, and it just happened to fit in with modern nicely. I don't believe that this is the case. See attached gif.
Note that the colors are significantly different. This indicates that either A) mozilla wasn't using windows to draw the resizer or B) mozilla is able to coerce windows into drawing the resizer so that it matches nicely.
OK. I got my hands on an XP machine and experimented. The deal is that the luna native resizer is translucent so that whatever background is under it shows through (Windows composites it on top of whatever is already there). Which is what you see in that screenshot. The "classic" native resizer is opaque and gray. In other system looks it could be translucent or not, depending on the look.
Product: Core → SeaMonkey
Assignee: shliang → nobody
QA Contact: pmac → themes
MASS-CHANGE: This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
Status: NEW → UNCONFIRMED
MASS-CHANGE: This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
MASS-CHANGE: This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state. If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way. If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar). If no action happens within the next few months, we move this bug report to an EXPIRED state. Query tag for this change: mass-UNCONFIRM-20090614
MASS-CHANGE: This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago. Because of this, we're resolving the bug as EXPIRED. If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component. Query tag for this change: EXPIRED-20100420
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → EXPIRED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: