1889851 - [Linux] The Orca screen reader fails to reads aloud warning message on hovering over saved values

Status: VERIFIED FIXED

(Firefox :: Disability Access, defect)

Description

[Ina Popescu, Desktop QA]

Found in

• Nightly 126.0a1

Affected versions

• Nightly 126.0a1

Tested platforms

• Affected platforms: Ubuntu
• Unaffected platforms: Windows10, macOS

Preconditions

• Install the Firefox en-US build
• Set browser.search.region to US in about:config
• Save several addresses and credit cards in about:preferences#privacy, Forms & Autofill section
• Orca screen reader is enabled

Steps to reproduce

1. Go to address form https://luke-chang.github.io/autofill-demo/basic.html
2. Double-click on any field to trigger the autofill dropdown
3. Use the preview feature for all autofill dropdown items

Expected result

• The screen reader reads aloud all the autofill dropdown items.

Actual result

• The screen reader does not read aloud the warning message shown upon hovering over the saved values.

Regression range

• I will search for any corresponding regression range, if applicable, and update the issue accordingly.

Comment 1

[Ina Popescu, Desktop QA]

I've narrowed down the regression range to:
Last good revision: https://hg.mozilla.org/mozilla-central/rev/533a3c2e587f7ea99fde847c499dbb77d1d7c623
First bad revision: https://hg.mozilla.org/mozilla-central/rev/d9466bebb4c96b99a227f35b5a7e86bd0c8f5bb5
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=533a3c2e587f7ea99fde847c499dbb77d1d7c623&tochange=d9466bebb4c96b99a227f35b5a7e86bd0c8f5bb5 , and it appears that the culprit is Bug1881582.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:enndeakin, since you are the author of the regressor, bug 1881582, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Neil Deakin]

The old behaviour seems off a bit, as it reads the warning as part of the options item at the bottom. This is due to the way the warning was implemented and was presumably never tested.

However, the warning can be different depending on which row is selected. I think we should instead read the warning after reading the name/address part.

Comment 4

[Neil Deakin]

Attachment: Bug 1889851, read the status label after the address info within the autofill dropdown, r=#credential-management-reviewers

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881582

Comment 6

[Ina Popescu, Desktop QA]

I encountered same issue while testing the autofill unified dropdown in Firefox 126.0b2 on macOS 13. It seems that the warning message is not being read aloud by VoiceOver. Please let me know if I should I create a separate issue for this. Thanks

Comment 7

[Neil Deakin]

No, it doesn't need a separate issue.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d36ea24e318
read the status label after the address info within the autofill dropdown, r=credential-management-reviewers,ssachdev

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5d36ea24e318

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:enndeakin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Neil Deakin]

Comment on attachment 9396666 [details]
Bug 1889851, read the status label after the address info within the autofill dropdown, r=#credential-management-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Allows the status text for the address formfill menu to be read correctly by screen readers.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only modifies the accessibility label for a menu which doesn't exist otherwise.
• String changes made/needed: None
• Is Android affected?: No

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9396666 [details]
Bug 1889851, read the status label after the address info within the autofill dropdown, r=#credential-management-reviewers

Approved for 126.0b5

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6d2ea27a05aa

Comment 14

[Hani Yacoub, Desktop QA]

Verified as fixed on Ubuntu 22.04 x64.