18899 - Win32: Turn OJI on by default, MOZ_OJI=1

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[drapeau]

Right now, parts of the Mozilla build use #ifdef's to determine whether to use
OJI.  These parts of the build can be re-written to use OJI as an XPCOM service,
which it is.  The benefit would be that the browser will have fewer compile-time
dependencies, the overall code base will be cleaner, and OJI can be built as
part of the default Mozilla build since it will not be too tightly coupled with
other modules.

Comment 1

[drapeau]

Jayashri Visvanathan is working on it.

Comment 2

[drapeau]

Jayashri Visvanathan is working on it.

Comment 3

[drapeau]

All occurrances in non-dead Mozilla code have been fixed; they now call on the
services of OJI as an XPCOM service.

The build rules may now be changed so that OJI is now part of the default build.
Can somebody do this, please?

Comment 4

[Chris McAfee]

This is now a build config issue, and the bug is not fixed
unitl --enable-oji is the default.  Reopening, over to leaf.

Comment 5

[Chris McAfee]

leaf

Comment 6

[Chris McAfee]

Adding jj for mac help.

On Linux, --enable-oji does MOZ_OJI=1, as well as
  FULL_STATIC_BUILD=
  NO_SHARED_LIB=

I assume this bug, on Unix, means "Make MOZ_OJI=1 by default,
and let --enable-oji be reduced to FULL_STATIC_BUILD=
and NO_SHARED_LIB=".  I think it's important to start building
this code and keep it building, but we don't want to clamp
down on linking statically/dynamically.  George, can you confirm?

Comment 7

[drapeau]

I don't fully understand the autoconf system or some of the defined symbols such
as the two you mention, Chris ("FULL_STATIC_BUILD" and "NO_SHARED_LIB").  Yes,
I'm asking that "MOZ_OJI=1" be the default option, but I don't know the effect
of the other two variables. I'm going to quote from a message I posted to the
netscape.public.mozilla.builds newsgroup in November about this, which basically
says what you've just said, then asks for help:

------

But, I don't know how to enable the option by default.  It *seems* to
me that the way to do it is to modify the "configure.in" file by
adding the line "MOZ_OJI=1" and making another small change to make a
"--disable-oji" option, then using autoconf to rebuild the configure
script.  But I don't know how to use autoconf, and I'm not sure if
this really is the right way to turn on OJI by default.

Also, in investigating the configure.in script, it looks like two
other variables are affected:

	FULL_STATIC_BUILD
	NO_SHARED_LIB

I don't know why these are involved.

Can somebody help me with both of these?

1) How to turn on OJI in the build by default

2) What these other two variables are about, and do they apply anymore
to OJI?
---------


I don't see any reason why OJI should be linked statically, since it's an XPCOM
service and not necessary in order for the rest of the browser to work.  On
Solaris, we link dynamically and it works just fine.  So if some Mozilla guru
can explain what those two variables mean, I think we're cool.

Chris, yes: I'm asking that to fix the bug on Unix, "MOZ_OJI=1" be set as the
default option.

Comment 8

[Chris McAfee]

MOZ_OJI looks like it conflicts with MOZ_JAVA.
Is MOZ_JAVA old?  Can we yank this config option?

Comment 9

[Chris McAfee]

Marking 22984 as a mild dependency, I have a fix in my tree that
builds OJI by default on Linux w/o yanking MOZ_JAVA out of any
source code.

Comment 10

[Chris McAfee]

Unix is done, mac & win32 still need to happen.

Comment 11

[Chris McAfee]

This is now the Win32 version of make OJI on-by-default,
filing a separate bug for Mac.

Comment 12

[Chris McAfee]

Mac version of this bug is 23024.

Comment 13

[Daniel (Leaf) Nunes]

already built all the time.

Comment 14

[Paul Wyskoczka]

Verified per leaf's comments.

Comment 15

[Jayashri Visvanathan]

Attachment: fix for 18899

Comment 16

[Chris McAfee]

This is marked fix, why the attachment?

Comment 17

[drapeau]

Sorry, mcafee, my doings here.  I had checked in Jayashri's changes before she
took off for a long vacation, but I had forgotten to post the patch to this
bug.  I've been lame about getting the patch attached, so I asked Jayashri to do
it.  I figure, better late than never.

That's all that's going on; she's just attaching the changes she had made, for
the record.

Comment 18

[Chris McAfee]

drapeau: ok.  This bug stays fixed/verified then.

Comment 19

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/c6a3abfac624
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/18899: Update content description string for synced tabs icon (https://github.com/mozilla-mobile/fenix/pull/18963)