1890097 - Perform quota checks for writable file stream in the parent process using dedicated task queues

Status: RESOLVED WONTFIX

(Core :: Storage: Bucket File System, task, P3)

Description

[Jan Varga [:janv]]

Just like SyncAccessHandle, WritableFileStream should perform quota checks in the parent process using dedicated task queues.
See bug 1809043 and bug 1809064.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Create a dedicated parent object for writable file streams independent from IPC; r=#dom-storage

Parent objects are usually actors as well, but the writable file stream is
special because it will need to do closing asynchronously and potentially have
multiple actors.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Prepare FileSystemWritableFileStreamResource for asynchronous closing; r=#dom-storage

Asynchronous closing can't be triggered from the destructor because it needs to
add a strong ref to self.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Prepare FileSystemWritableFileStream for asynchronous creation; r=#dom-storage

FileSystemWritableFileStreamResource::Create now returns a MozPromise, but the
creation does nothing on other threads for now.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Register active FileSystemWritableFileStreams in FileSystemDataManager; r=#dom-storage

Active FileSystemWritableFileStreams will prevent FileSystemDataManager from
closing.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Wait for close to be finished in the parent before calling the resolver for FileSystemWritableFileStreamParent::RecvClose; r=#dom-storage

The close in the parent is going to be asynchronous as well, so it won't be
guaranteed anymore that the unlocking happens synchronously immediatelly after
receiving the close message.

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Perform quota checks for writable file stream in the parent process using dedicated task queues; r=#dom-storage

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Perform quota checks for writable file stream in the parent process using dedicated task queues - all in one; r=#dom-storage

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Perform quota checks for writable file stream in the parent process using dedicated task queues - all in one - build error; r=#dom-storage

Comment 9

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Perform quota checks for writable file stream in the parent process using dedicated task queues - all in one - test failure; r=#dom-storage

Comment 10

[Jan Varga [:janv]]

Attachment: Bug 1890097 - Perform quota checks for writable file stream in the parent process using dedicated task queues - all in one - non-unified build error; r=#dom-storage