1890197 - Fails to warn when closing multiple tabs, WHEN SOME TABS ARE PINNED (with automatic session restore enabled)

Status: NEW

(Firefox :: Tabbed Browser, defect, P3)

Description

[wb0gaz]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

Version 118.0.1. When N tabs are pinned and 0 or 1 non-pinned tabs are open, exiting from Windows version of Firefox (X on far upper right corner) fails to warn before exit, even though setting "confirm before closing multiple tabs" is selected. Instead, firefox exits immediately.

Actual results:

Version 118.0.1. When N tabs are pinned and 0 or 1 non-pinned tabs are open, exiting from Windows version of Firefox (X on far upper right corner) fails to warn before exit, even though setting "confirm before closing multiple tabs" is selected. Instead, firefox exits immediately.

Expected results:

Warning dialog before exit, ask for confirmation.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Ada C.]

Hi, wb0gaz

If possible, please verify in about:preferences, under Tabs section, if the following feature is enabled: "Confirm before closing multiple tabs". If the option is enabled and upon closing the Firefox window the prompt still does not appear, please let me know.

Comment 3

[wb0gaz]

12-April-2024

Hello Ada C. - per the original report (and re-confirmed):

(( even though setting "confirm before closing multiple tabs" is selected ))

I have captured screen shot from firefox settings including this setting, but I do not know how to attach screen shot (.png file) to this reply.

I can perform other tests to assist you, and can attach screen shots if you can tell me how.

Thank you for looking into this issue

Comment 4

[wb0gaz]

Attachment: 1891097-from-op.png

I now realized how to attach screen shot, so this shows setting you asked about.

Comment 5

[BugBot [:suhaib / :marco]]

A needinfo is requested from the reporter, however, the reporter is inactive on Bugzilla. Given that the bug is still UNCONFIRMED, closing the bug as incomplete.

For more information, please visit BugBot documentation.

Comment 6

[wb0gaz]

Hello, I wish to add clarifying information to this issue (which remains a problem for me on Windows/64 with currently updated Firefox.)

I use "pinned" tabs for several web sites that I access frequently. This makes the tabs smaller (and to the left). As of today (04 Nov 2024) I re-tested the problem and was able to reproduce it by having pinned (and open "within" the pin tab) tabs open, and one non-pinned (regular) tab open (along with the pinned tabs). In that case, firefox exits (from the "X" windows button on the upper right) immediately without prompt. If I have MORE THAN ONE non-pinned tab open, then firefox prompts for confirmation before exiting.

As I use the "pinned" tabs in the same fashion as regular tabs (except that they are present on my browser toolbar so I can access them without opening a new tab), this behavior is the problem from which I posted the issue in the first place.

I hope this is helpful, and I am happy to append further information should that also be helpful!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hi wb0gaz, out of curiosity, when you re-launch the browser, are your pinned tabs restored? And presumably when you experience this, you only have a single browser window open?

Comment 8

[wb0gaz]

Thank you Mike for the question!
Right now running 118.0.1 on Windows 10 64-bit (updated current) on a Lenovo Yoga 11e (1368/768 screen), using a fairly slow (by modern standards) DSL connection. The machine is running nothing (as an application) except this instance of Firefox.

I just performed this experiment:

1. Start firefox (routine) and then open this (github) page in preparation to respond. There are three pinned tabs (all are open/active; they are e-mail accounts) and one normal tab (this session)
2. Click the X button in the far upper right corner (windows decoration); Firefox exits immediately without any warning dialog box.
3. Start firefox (again) and I see the following tab configuration:
   The three pinned tabs (all are active/open/running as expected)
   One normal tab (this github session), which returned to this response input box (where I left it.)
   I'm typing this response on that tab (which was opened in the prior start of firefox, and preserved across the "exit without warning" event.

Happy to provide any further input or conduct any further tests that might help you.

Comment 9

[Dão Gottwald [:dao]]

From a quick look, we should probably stop excluding pinned tabs here when session restore is enabled: https://searchfox.org/mozilla-central/rev/f53c09a22edc700ab1a9eaaf4da0f0dd9f11bff3/browser/components/BrowserGlue.sys.mjs#3444-3461

When automatic session restore is disabled, it makes sense to exclude pinned tabs there because they will be restored regardless of the session restore setting.

Comment 10

[wb0gaz]

(I am the original post author)
I realized Firefox is (reasons unknown to me) not auto updating on this machine ("updates managed by your organization" or wording to that effect, even though this machine is not part of an organization/domain). That condition is not intentional. Version 118 has been in use to date. I forced update (today January 23 2025) by installing new over the existing version and am now at version 134, restarted Firefox, and reproduced the issue that motivated the initial posting in early 2024.

Comment 12

[Ada C.]

Hi, wb0gaz

Been verifying this issue on Windows 10 using Firefox 145.0 and Nightly 147.0a1 (2025-11-10) and I managed to get the confirmation prompt when I try to close the Firefox window; the prompt is mentioning three tabs unpinned, and after closing and reopening the browser, the two pinned tabs remain there. Could you confirm if the issue is still reproducible on your machine?

Comment 13

[BugBot [:suhaib / :marco]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:sthompson, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 14

[Stephen Thompson [:sthompson]]

Testing with Nightly 147.0a1 (2025-12-02) (aarch64) macOS

Configuration:

• (checked) Ask before closing multiple tabs
• (unchecked) Ask before quitting with Cmd+Q
• (checked) Open previous windows and tabs
• 1 window, 2 pinned tabs, 1 unpinned tab

Closing the window using the OS close button (window decoration):

• Popup appears "Close 3 tabs?"
• comes from window.onclose handler https://searchfox.org/firefox-main/rev/1d09788fc8234e4ab0dc3b9f2a99ff66cb90e274/browser/base/content/browser-main.js#40 which feeds through to using the number of open tabs https://searchfox.org/firefox-main/rev/1d09788fc8234e4ab0dc3b9f2a99ff66cb90e274/browser/base/content/browser.js#3829-3832

Closing the window using the Cmd+Q shortcut (should be similar to Alt+F4 on Windows):

• No popup appears and the browser closes
• comes from the BrowserGlue._onQuitRequest code that Dao mentioned in comment 9 https://searchfox.org/firefox-main/rev/1d09788fc8234e4ab0dc3b9f2a99ff66cb90e274/browser/components/BrowserGlue.sys.mjs#1448-1459 which discounts pinned tabs

It's possible that this behavior changed in 2025 between 135 and 145. Comment 1, comment 6, comment 8 all mentioned closing using the Windows OS window close button, but the described behavior sounds consistent with BrowserGlue._onQuitRequest. The described behavior in comment 12 sounds consistent with window.onclose.