Closed Bug 1890361 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 45610 - Add borders around canvas grid cells

Categories

(Core :: Graphics: Canvas2D, task, P4)

Product:
Core
Component:
Graphics: Canvas2D
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45610 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45610
Details from upstream follow.

Jean-Philippe Gravel <jpgravel@chromium.org> wrote:

Add borders around canvas grid cells

When generating grids of canvases in a WPT test, space is limited
because the whole grid must fit in the area screenshotted by the test
runner. Therefore, tests must maximize the utilisation of their canvas
area. This usually means using smaller canvas (to fit more test cases
in the grid) and drawing shapes that almost fill the whole canvas
surface (because canvases are smaller). To more easily see if this is
properly done, it's helpful to see the boundary of the canvas. This
also helps in knowing if the drawing overflows the canvas.

Bug: 330885075
Change-Id: I411e0861829614162fee1f16854c127ae362a5c9

Reviewed-on: https://chromium-review.googlesource.com/5431314
WPT-Export-Revision: 9a02b231221665c1437b9351d5143470f77fcae9

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

FAIL : 4
TIMEOUT: 2

Chrome

PASS : 6

Safari

FAIL : 4
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb058811c779 [wpt PR 45610] - Add borders around canvas grid cells, a=testonly https://hg.mozilla.org/integration/autoland/rev/6aa6e087cd68 [wpt PR 45610] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/eb058811c779
https://hg.mozilla.org/mozilla-central/rev/6aa6e087cd68

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.