1890367 - Cannot draw two consecutive lines in a PDF

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Calixte Denizet (:calixte)]

STR:

• open a pdf;
• click on the ink button (button with the pen icon);
• draw something without release the mouse button;
• release the button;
• draw something else.

The second draw isn't possible.

This is a regression from bug 1866850 and especially from:
https://github.com/mozilla/pdf.js/pull/17823

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Don't add an already added editor (bug 1890367) (#17907)

Comment 2

[Calixte Denizet (:calixte)]

[Tracking Requested - why for this release]:
This bug makes the ink editor really painful to use.

Comment 3

[Calixte Denizet (:calixte)]

Attachment: Bug 1890367 - Don't add an already added editor in the pdf viewer

Comment 4

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: The ink editor will be unusable
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: STR in comment#0
• Risk associated with taking this patch: Low
• Explanation of risk level: Small and self-contained change
• String changes made/needed: No
• Is Android affected?: no

Comment 5

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/51feed7ace1d

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 126.0a1 (2024-04-06) on Windows 10x64 by following steps from comment 0. The second line cannot be drawn correctly because the move and pen are both activated in the same time.
The issue is verified fixed with Firefox 125.0RC1 (20240408174943) on Windows 10x64, macOS 13 and Ubuntu 23.10 while following steps from comment 0. Multiple consecutive lines can be correctly drawn using the Draw option.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox126 (nightly). However, the bug still has low severity.

:marco, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 8

[Donal Meehan [:dmeehan]]

Resolving as fixed, since Bug 1890596 landed in central and contains the fix

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with 126.0a1 (2024-04-10) on Windows 10x64, macOS 12 and Ubuntu 23.10.