1890385 - Add remaining size tokens

Status: RESOLVED FIXED

(Firefox :: Theme, task, P3)

Description

[Jules Simplicio [:jules]]

We've been adding size (height and width) design tokens to capture existing patterns. Folks have been relying on these tokens so let's add some remaining patterns.

What we have today:

• --size-item-small: 16px;
• --size-item-medium: 28px;
• --size-item-large: 32px;

Proposals for more patterns to capture:

• Assign 24px, which is a more re-ocurring pattern, to --size-item-medium (which is only being used to size the small button's height today), and directly assign 28px to button height instead.
• --size-item-xsmall: 12px;
• --size-item-xlarge: 48px;
• --size-item-xxlarge: 64px;

Comment 1

[Stuart Colville [:muffinresearch]]

Check in with jules to see that this is still accurate.

Comment 2

[Jules Simplicio [:jules]]

Attachment: Bug 1890385 - Add remaining size tokens r?#reusable-components-reviewers,maxx

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a344e4bedee
https://hg.mozilla.org/integration/autoland/rev/3f8fd8ef8c8e
Add remaining size tokens r=maxx,reusable-components-reviewers,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,home-newtab-reviewers,sidebar-reviewers,urlbar-reviewers,nchevobbe,nsharpley,hjones,mtigley,Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ecf6ce4c6f3f
https://hg.mozilla.org/integration/autoland/rev/119d1289897d
Revert "Bug 1890385 - Add remaining size tokens r=maxx,reusable-components-reviewers,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,home-newtab-reviewers,sidebar-reviewers,urlbar-reviewers,nchevobbe,nsharpley,hjones,mtigley,Standard8" for causing bc failures on browser_parsable_css.js

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on browser_parsable_css.js

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8f91b63be1a3
https://hg.mozilla.org/integration/autoland/rev/126b6e5081d6
Add remaining size tokens r=maxx,reusable-components-reviewers,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,home-newtab-reviewers,urlbar-reviewers,nchevobbe,nsharpley,hjones,mtigley,Standard8

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1c9bd77e0d6d
https://hg.mozilla.org/integration/autoland/rev/6bbc1b86dd80
Revert "Bug 1890385 - Add remaining size tokens r=maxx,reusable-components-reviewers,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,home-newtab-reviewers,urlbar-reviewers,nchevobbe,nsharpley,hjones,mtigley,Standard8" for causing mochitests failures in browser_parsable_css.js.

Comment 8

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_parsable_css.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property --icon-size-default is not referenced -

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a03744f6112d
https://hg.mozilla.org/integration/autoland/rev/242c8086b83e
Add remaining size tokens r=maxx,reusable-components-reviewers,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,home-newtab-reviewers,urlbar-reviewers,nchevobbe,nsharpley,hjones,mtigley,Standard8

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/242c8086b83e