1890476 - Update android nightly application-services version bump to new version 94d15144656f2fa49e3de385bb1ec07da446d6e4 from 2024-04-09 05:02:47

Status: RESOLVED DUPLICATE of bug 1890709

(Firefox for Android :: General, enhancement)

Description

[Update Bot]

This update covers 9 commits, including 2 new upstream commits I've never filed a bug on before. (They're the top 2.). Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

94d15144656f2fa49e3de385bb1ec07da446d6e4 by Ben Dean-Kawamura

https://github.com/mozilla/application-services/commit/94d15144656f2fa49e3de385bb1ec07da446d6e4
Authored: 2024-04-05 13:51:29 -0400
Committed: 2024-04-08 21:14:42 +0000

Adding a UDL file for interrupt-support

This allows us to expose the shutdown method, which I plan to use for
https://bugzilla.mozilla.org/show_bug.cgi?id=1889700.

I also cleaned up some doc strings that refered to deleted functions.

Files Added:

• components/support/interrupt/build.rs
• components/support/interrupt/src/interrupt_support.udl

Files Modified:

• Cargo.lock
• components/support/interrupt/Cargo.toml
• components/support/interrupt/src/shutdown.rs

---

0d631b6c6ee69a744041c781fb0bd8d602dc171a by Ben Dean-Kawamura

https://github.com/mozilla/application-services/commit/0d631b6c6ee69a744041c781fb0bd8d602dc171a
Authored: 2024-04-05 14:13:00 -0400
Committed: 2024-04-08 14:03:54 +0000

Allow readers and writers to concurrently operate

The initial design for the relevancy DB had a big issue: both
connections were behind the same mutex. This meant that writers would
block readers and vice-versa.

Changed the code so that we use a separate mutex for the reader and
writer connections. This means we can both ingest and query the store
at the same time. We're currently still limited to 1 concurrent reader,
but I think that it should be possible to increase that if we need it in
the future.

Files Modified:

• components/relevancy/src/db.rs

---

e95b9ea3e839169f8818975e52ec572e57934189 by Ben Dean-Kawamura

https://github.com/mozilla/application-services/commit/e95b9ea3e839169f8818975e52ec572e57934189
Authored: 2024-04-04 14:00:13 -0400
Committed: 2024-04-05 15:35:38 +0000

Bug 1888560 - Lazily load the relevancy database

Files Modified:

• components/relevancy/src/db.rs
• components/relevancy/src/lib.rs
• components/relevancy/src/populate_interests.rs
• components/relevancy/src/relevancy.udl

---

145160f13b6f9b0aa968162e66986edff3f51999 by Lina Butler

https://github.com/mozilla/application-services/commit/145160f13b6f9b0aa968162e66986edff3f51999
Authored: 2024-04-04 13:13:35 -0700
Committed: 2024-04-04 20:39:09 +0000

remote_settings: Add ConfigError message.

Files Modified:

• components/remote_settings/src/error.rs

---

0152f26ed5ddf6c9e93703ccb156749578092a28 by Lina Butler

https://github.com/mozilla/application-services/commit/0152f26ed5ddf6c9e93703ccb156749578092a28
Authored: 2024-04-03 18:55:01 -0700
Committed: 2024-04-04 19:38:20 +0000

suggest: Add SuggestStoreBuilder.remote_settings_server and deprecate remote_settings_config.

Files Modified:

• CHANGELOG.md
• components/suggest/src/store.rs
• components/suggest/src/suggest.udl

---

7da3225a726c9c38ff1bddf7117561d8d7d144c4 by Lina Butler

https://github.com/mozilla/application-services/commit/7da3225a726c9c38ff1bddf7117561d8d7d144c4
Authored: 2024-04-03 18:54:29 -0700
Committed: 2024-04-04 19:38:20 +0000

remote_settings: Add RemoteSettingsServer and deprecate RemoteSettingsConfig.server_url.

Files Modified:

• CHANGELOG.md
• components/nimbus/examples/experiment.rs
• components/nimbus/src/lib.rs
• components/nimbus/src/nimbus.udl
• components/nimbus/src/stateful/client/mod.rs
• components/nimbus/tests/common/mod.rs
• components/nimbus/tests/test_fs_client.rs
• components/remote_settings/src/client.rs
• components/remote_settings/src/config.rs
• components/remote_settings/src/error.rs
• components/remote_settings/src/lib.rs
• components/remote_settings/src/remote_settings.udl
• components/suggest/src/benchmarks/client.rs
• components/suggest/src/lib.rs
• components/suggest/src/suggest.udl
• components/support/nimbus-cli/src/sources/experiment_list.rs

---

5ab11bbd1ffd86a0d6cb85f35bee913fd6ab14fb by Ben Dean-Kawamura

https://github.com/mozilla/application-services/commit/5ab11bbd1ffd86a0d6cb85f35bee913fd6ab14fb
Authored: 2024-04-03 14:19:29 -0400
Committed: 2024-04-04 17:30:22 +0000

Bug 1889440 - Fixing the suggest database migration

The previous migration failed because I was passing 2 statements to
execute(), but that will only run one. I should have used
execute_batch. Added a new migration that should fix things and also
won't break things for users where we created a fresh v18 database that
did have the dismissed_suggestions table.

Added a test to check if the schemas of a fresh database and an upgraded
database are the same. Hopefully this prevents the next issue like
this. Updated the SQL so that it doesn't have any leading spaces. This
makes the comparision easier.

Files Modified:

• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/support/sql/src/open_database.rs

---

6c6951cdfe8d1fb839d92e56950a790783c1bded by Ben Dean-Kawamura

https://github.com/mozilla/application-services/commit/6c6951cdfe8d1fb839d92e56950a790783c1bded
Authored: 2024-03-26 14:03:24 -0400
Committed: 2024-04-04 15:32:33 +0000

Updating the fxa-client example

Added flags to:

• Request the session scope.
• Control how log messages get printed to the console.

Updated the code to re-authenticated using the existing data rather than
throwing it away and starting from scratch.

These changes make it possible to repro
https://bugzilla.mozilla.org/show_bug.cgi?id=1887071

• run cargo run -- --log -d devices with fresh credentials.
  • Any command should do, but I used devices
  • The client should ask you to login and paste your credentials
  • You should see the device list printed out
• In a browser session, change your FxA password
• run cargo run -- --log -d devices again
  • The client should tell you there was an auth-problem and ask you to
    reauthenticate.
  • After you paste the reauthentication URL you should see an error
    printed out

Files Modified:

• Cargo.lock
• examples/autofill-utils/src/autofill-utils.rs
• examples/cli-support/src/fxa_creds.rs
• examples/fxa-client/Cargo.toml
• examples/fxa-client/src/main.rs
• examples/places-utils/src/places-utils.rs
• examples/sync-pass/src/sync-pass.rs
• examples/tabs-sync/src/tabs-sync.rs
• testing/sync-test/src/main.rs

---

e6ccfed09ebe663f464a33968f42e656c152e584 by Ben Dean-Kawamura

https://github.com/mozilla/application-services/commit/e6ccfed09ebe663f464a33968f42e656c152e584
Authored: 2024-03-27 09:59:21 -0400
Committed: 2024-04-04 14:34:31 +0000

Bumping UniFFI to 0.27.1

Files Modified:

• Cargo.lock
• Cargo.toml
• DEPENDENCIES.md
• components/external/glean
• components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/NimbusHelpers.kt
• gradle/libs.versions.toml
• megazords/full/DEPENDENCIES.md
• megazords/full/android/dependency-licenses.xml
• megazords/ios-rust/DEPENDENCIES.md
• megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.pbxproj
• megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
• megazords/ios-rust/focus/DEPENDENCIES.md
• tools/dependency_summary.py

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=11ba22b5c3b92b3b29bc7b5252525b32e699848d

Comment 3

[Update Bot]

Attachment: Bug 1890476 - Update android nightly application-services version bump to 94d15144656f2fa49e3de385bb1ec07da446d6e4

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

• toolchain-linux64-android-gradle-dependencies - 1 of 1 failed (failed: GOu9KAO8SLC5E97fuNL7vQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Donal Meehan [:dmeehan]]

There is a stack up that address this https://lando.services.mozilla.com/D206979/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16203d63eb0d
Update android nightly application-services version bump to 94d15144656f2fa49e3de385bb1ec07da446d6e4 CLOSED TREE

Comment 7

[Cristian Tuns]

Backed out - part of Bug 1888683 (causing toolchain bustages without Bug 1888683)
Toolchains link: https://treeherder.mozilla.org/logviewer?job_id=454131416&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/419ddd73a8540888f59c215b179f8fd54eaafc1e

Comment 8

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).