1890576 - MOZGlobalAppearance doesn't account for ui.systemUsesDarkTheme

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

Which means that changing that causes e.g. a light titlebar but dark toolbar and other unreadable stuff.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1890576 - Simplify and make MOZGlobalAppearance more correct. r=mstange,#mac-reviewers

Make it account for stuff like ui.systemUsesDarkTheme, otherwise the
chrome and macOS may have a different idea about what the global
appearance is.

Remove observer from nsLookAndFeel. Nothing in nsLookAndFeel reads from
MOZGlobalAppearance, and we want the MOZGlobalAppearance to derive from
nsLookAndFeel, not the other way around.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1890576 - Make root element color-scheme affect widget appearance. r=mstange,#mac-reviewers

Instead of relying on the embedder color-scheme directly, use the
color-scheme property to determine the nsCocoaWindow's appearance.

This is more in line with what content does, would've prevented this bug
from existing altogether, and avoids the need for MOZGlobalAppearance.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f2ae428fb88
Simplify and make MOZGlobalAppearance more correct. r=mstange,mac-reviewers
https://hg.mozilla.org/integration/autoland/rev/91cfcfc5935b
Make root element color-scheme affect widget appearance. r=mstange,mac-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5f2ae428fb88
https://hg.mozilla.org/mozilla-central/rev/91cfcfc5935b