1890637 - [wpt-sync] Sync PR 45631 - Don't immediately invalidate ScriptPromiseResolver::resolver_ when created while detached

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45631 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45631
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Don't immediately invalidate ScriptPromiseResolver::resolver_ when created while detached

We still won't ever resolve or reject it, but this ensures that it
is observed as a promise that never settles, rather than as
undefined.

Change-Id: I8549071de08b6730aa416af171ce86586c8950a0

Reviewed-on: https://chromium-review.googlesource.com/5427412
WPT-Export-Revision: 880a859b024be15087916e78726c814a094ba9fa

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=130b8259a57b26d9aa8977fd109b0dbdc5510d25

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Safari

OK : 2
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /trust-tokens/end-to-end/has-trust-token-with-no-top-frame.tentative.https.html [wpt.fyi]: SKIP (Safari: OK)
• /storage/buckets/detached-iframe.https.html [wpt.fyi]
  • Verify open() on detached iframe returns an error: FAIL (Safari: FAIL)
  • Verify keys() on detached iframe returns an error: FAIL (Safari: FAIL)
  • Verify delete() on detached iframe returns an error: FAIL (Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /trust-tokens/end-to-end/has-trust-token-with-no-top-frame.tentative.https.html [wpt.fyi]: SKIP (Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c23c3bc7aa
[wpt PR 45631] - Don't expect an undefined promise in a detached iframe, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/17c23c3bc7aa