Perma a11y [Tier2] browser/components/translations/tests/browser/browser_translations_about_preferences_settings_ui.js | single tracking bug
Categories
(Firefox :: Translations, defect, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr115 | --- | unaffected |
firefox124 | --- | unaffected |
firefox125 | --- | unaffected |
firefox126 | --- | disabled |
firefox127 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: ayeddi)
References
(Regression)
Details
(Keywords: intermittent-failure, intermittent-testcase, regression)
Attachments
(1 file)
Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=454211539&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aCWmakLhS9yeO8o5RClUZQ/runs/0/artifacts/public/logs/live_backing.log
TEST-PASS | browser/components/translations/tests/browser/browser_translations_about_preferences_settings_ui.js | Number of languages added is 4 -
[task 2024-04-10T20:27:46.999Z] 20:27:46 INFO - Buffered messages finished
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - TEST-UNEXPECTED-FAIL | browser/components/translations/tests/browser/browser_translations_about_preferences_settings_ui.js | Node is not accessible via accessibility API: id: , tagName: moz-button, className: translations-settings-delete-icon -
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - Stack trace:
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochikit/content/browser-test.js:test_ok:1592
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:752
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:1161
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:1137
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:1254
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochitests/content/browser/browser/components/translations/tests/browser/browser_translations_about_preferences_settings_ui.js:testLanguageList:164
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochitests/content/browser/browser/components/translations/tests/browser/browser_translations_about_preferences_settings_ui.js:test_translations_settings_always_translate:110
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-04-10T20:27:47.001Z] 20:27:47 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-04-10T20:27:47.002Z] 20:27:47 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-04-10T20:27:47.002Z] 20:27:47 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-04-10T20:27:47.002Z] 20:27:47 INFO - TEST-PASS | browser/components/translations/tests/browser/browser_translations_about_preferences_settings_ui.js | Ukrainian removed from Always Translate -
Updated•10 months ago
|
Comment 1•10 months ago
|
||
Set release status flags based on info from the regressing bug 1876286
Comment 2•10 months ago
|
||
We have filed a Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1888684 to take care of this issue.
Thanks!
Comment 3•10 months ago
|
||
Hello @ayeddi,
As mentioned previously, we've filed a bug to address the accessibility issues, which may take some time to resolve completely. In the meantime, do you have any short-term solutions or recommendations to address the issue temporarily?
Thank you!
Assignee | ||
Comment 4•10 months ago
|
||
(In reply to Meera Murthy from comment #3)
Hello @ayeddi,
As mentioned previously, we've filed a bug to address the accessibility issues, which may take some time to resolve completely. In the meantime, do you have any short-term solutions or recommendations to address the issue temporarily?Thank you!
Hello Meera!
Thank you for tagging. I've run the a11y-checks locally and it seems that the tests are failing because the click is sent to the <moz-button>
container while the <button>
itself is its child within a shadow DOM. Thus, the accessible cannot be found by the test harness. You could update the tests to click on that inner <button>
and the accessibility tests should be able to proceed with the testing. I'll also comment on the label of the button in the bug you've referenced.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 7•10 months ago
|
||
Set release status flags based on info from the regressing bug 1876286
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 9•10 months ago
|
||
Since the click event is dispatched on the <moz-button>
wrapper which listens to a click by itself, the Accessibility Utils do not proceed with accessing the element internals and test the <button>
itself during these tests, thus failing a11y_checks. A user won't be dispatching a click even on the container in the real life, but clicking a button, thus we may change the way we trigger the click event by replacing the dispatch event with .click()
method to allow the accessibility tests to run on the <button>
and ensure these buttons are, in fact, accessible now and will remain accessible with any future code changes.
Updated•10 months ago
|
Comment 10•10 months ago
|
||
Comment hidden (Intermittent Failures Robot) |
Comment 12•10 months ago
|
||
bugherder |
Comment 13•10 months ago
|
||
The patch landed in nightly and beta is affected.
:ayeddi, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox126
towontfix
.
For more information, please visit BugBot documentation.
Comment 14•10 months ago
|
||
This is a test-only change and doesn't need a formal uplift request.
I will take this in a later push to beta.
Comment 15•10 months ago
|
||
Nightly only for now
Comment hidden (Intermittent Failures Robot) |
Description
•