189089 - port nspr w32 now.c fix to directory

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

see bug 188396 - now.c won't work for dates after 2038. windows provides an api
for that, though, so it should be used.

bug 188396 already contains the patch for the nspr now.c, this should be simple.

Comment 1

[Soeren Unruh]

Attachment: Integrated NSPR W32 now.c fix

Comment 2

[Rich Megginson]

Looks ok - should now be declared long long, or is that equivalent to __int64 on
Windows?  If this is exactly the same as the NSPR fix, then it's probably ok.

Comment 3

[Wan-Teh Chang]

Rich,

I guess you are right.  We probably should declare 'now' as:

#ifdef __GNUC__
    long long now;
#else
    __int64 now;
#endif

Apparently gcc on Windows also understands Microsoft Visual
C++'s __int64 type because the code compiles.

Comment 4

[Soeren Unruh]

The change is exactly the one from NSPR.
Only the #ifdef __GNUC__ was added to the NSPR code later, so I included it.

now is declared as __int64 only for WIN32, Unix systems use gettimeofday() and a
long long now.

Comment 5

[Mark Smith [:mcs]]

Fix committed to the trunk:

mozilla/directory/c-sdk/config/now.c
  new revision: 5.1; previous revision: 5.0
    Fix 189089 - port nspr w32 now.c fix to directory.
        See bug # 188396 - NSPR should not use ftime on windows.
        This fixes a potential Year 2038 issue.

Please re-open this bug if we need this fix on ldapcsdk_50_client_branch right away.

Comment 6

[Frankie]

Spam for bug 129472