1890915 - A lot of warnings in `nsDOMAttributeMap::IndexedGetter()` when you run some editing WPT

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It warns that it's called with too big index.

It's called by EditorBase::CloneAttributesWithTransaction(), HTMLEditor::CopyAttributes() and HTMLEditor::InsertLinkAroundSelectionAsAction() via nsDOMAttributeMap::Item(). A call in EditorBase::CloneAttributesWithTransaction() obviously causes the warning and the other callers look like fine.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1890915 - Make `EditorBase::CloneAttributesWithTransaction()` collect all attributes before updating the DOM tree r=m_kato!

while (RefPtr<Attr> attr = attributes->Item(0)) causes a warning in
nsDOMAttributeMap::IndexedGetter() because of out of bounds. Additionally,
we should not make a loop with live DOM tree information if the loop updates
the DOM tree. Therefore, this patch makes it collect all attributes first
before touching the DOM tree.

Depends on D207240

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b17d2a2a7ae
Make `EditorBase::CloneAttributesWithTransaction()` collect all attributes before updating the DOM tree r=m_kato

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4b17d2a2a7ae