1890929 - Inline module scripts with no dependencies should be executed after a full task

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P4)

Description

[Domenic Denicola]

See test at https://github.com/web-platform-tests/wpt/pull/45660 and spec discussion at https://github.com/whatwg/html/pull/10272.

It appears Gecko instead runs them immediately.

Chrome and Safari run them after a full task. If you believe that's a good idea, please let me know and we can start a spec discussion. I don't think Gecko's behavior is very good though because it's impossible to spec cleanly, given the existence of top-level await.

Comment 1

[Henri Sivonen (:hsivonen) (on vacation)]

jonco, smaug, who should look at this?

Comment 2

[Domenic Denicola]

The latest plan is to run them after a full task. The spec and tests PR have been updated.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Henri Sivonen (:hsivonen) from comment #1)

jonco, smaug, who should look at this?

jonco :)

Comment 4

[Jon Coppeard (:jonco)]

Yoshi, could you look into this at some point?

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1890929 - Part 1: Execute non-parser generated inline module scripts asynchronously.

Refactors execution behavior to run asynchronously for inline scripts that are
not generated by the parser.

spec:
https://html.spec.whatwg.org/#prepare-the-script-element

Step 32. If el does not have a src content attribute:
2. type: "module"
...
3. Fetch an inline module script graph, given source text, base URL, settings object, options, and with the following steps given result:
1. Queue an element task on the networking task source given el to perform the following steps:
1. Mark as ready el given result.

Step 33. If ... el's type is "module":
3. Otherwise, if el is not parser-inserted:
3.2.1 Execute the script element scripts[0].

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1890929 - Part 2: update inline-module-order.html.

According to the spec, non-parser-inserted inline module scripts should
execute in order.

https://html.spec.whatwg.org/#prepare-the-script-element

Step 33. If ... el's type is "module":
...
3. Otherwise, if el is not parser-inserted:
1. Let scripts be el's preparation-time document's list of scripts that will execute in order as soon as possible.
2. Append el to scripts.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1890929 - Part 3: Remove WPT ini files.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8b8c0c1b0ecf
https://hg.mozilla.org/integration/autoland/rev/02f1cb7eab5e
Part 1: Execute non-parser generated inline module scripts asynchronously. r=jonco
https://github.com/mozilla-firefox/firefox/commit/9b955b20bf1b
https://hg.mozilla.org/integration/autoland/rev/e50478c15f92
Part 2: update inline-module-order.html. r=jonco
https://github.com/mozilla-firefox/firefox/commit/5972f73d9ad8
https://hg.mozilla.org/integration/autoland/rev/897e20364ff9
Part 3: Remove WPT ini files. r=jonco

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/02f1cb7eab5e
https://hg.mozilla.org/mozilla-central/rev/e50478c15f92
https://hg.mozilla.org/mozilla-central/rev/897e20364ff9