189106 - Cannot delete helper apps which have special characters in the MIME type

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[piers]

If you create a helper app with special characters in the MIME type (e.g. £, Æ,
Ω, ¶, ý), you then can't remove or edit it.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

can reproduce on win98 build from jan 12

Comment 2

[piers]

Steps to reproduce:
1. Open Prefs -> Hepler Applications;
2. Click "New Type";
3. As the MIME type, enter "£" (no quotes);*
4. Click OK;
5. Select the newly created entry.

* On a non-UK keyboard you can press Alt+0163 (on Win) to get "£"

Actual results: "Edit" and "Remove" buttons are disabled.

Expected: Buttons are enabled, and actions possible.

Comment 3

[Boris Zbarsky [:bzbarsky]]

biesi has volunteered to debug this...

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/content/pref-applications.js#201
here, uri is "", so the HandlerOverride stuff doesn't exactly get useful info,
later on at
http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/content/pref-applications.js#227
the isEditable attribute is "" so the buttons get disabled.

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK. I know what's up here...  The problem is that GetResource() expects (and
demands) an ascii string.  We pass it some random stuff that XPConnect strips to
be 7-bit-clean and things break.  We need to fix that by using
GetUnicodeResource, basically (or fixing GetResource...) or we need to do
filtering of the content-type string prior to it getting into the
overrideHandler code.

This is enough of an edge case that I think fixing it by hacking the existing
rdf-munging code is silly; I'd rather implement a service for doing it like I
keep meaning to.... then that can encapsulate all the logic that is in oodles of
places right now.

Piers, even when I fix this bug, that won't let you delete the entries you
already have that are messed up.... the problem you have is that your
mimeTypes.rdf file already contains corrupted data.  Ths fix will be to not
allow such data into the datasource rather than to deal with its presence in
there.  If you don't want to just trash mimeTypes.rdf, let me know (e-mail or
irc) and I can help you delete the bogus entries.

Comment 6

[Boris Zbarsky [:bzbarsky]]

.

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 190951 has been marked as a duplicate of this bug. ***

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: use GetUnicodeResource (note that the C++ use UTF8 already, so needs no changing)

This is causing internationalization issues too, so we really need to fix this.
 Patch is a simple search/replace s/GetResource/GetUnicodeResource/ on the
override handler.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 112888 [details] [diff] [review]
use GetUnicodeResource (note that the C++ use UTF8 already, so needs no changing)

sr=dmose

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 112888 [details] [diff] [review]
use GetUnicodeResource (note that the C++ use UTF8 already, so needs no changing)

Potentially serious intl problem.... very straightforward fix to just use the
unicode api...

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 112888 [details] [diff] [review]
use GetUnicodeResource (note that the C++ use UTF8 already, so needs no changing)

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 12

[Boris Zbarsky [:bzbarsky]]

fixed

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 137276 has been marked as a duplicate of this bug. ***

Comment 14

[Chris Petersen]

Verified in the Win32 2003-03-13-04 NB under Win XP .