Closed Bug 1891445 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 45709 - [line-clamp] Make `line-clamp` create a new BFC

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45709 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45709
Details from upstream follow.

Andreu Botella <abotella@igalia.com> wrote:

[line-clamp] Make line-clamp create a new BFC

Although -webkit-line-clamp has always created an independent
formatting context, our prototype implementation of line-clamp
initially made it so the line-clamp property (but not
-webkit-line-clamp) didn't necessarily create one.

However, in the course of implementing this proposal, the fact that it
did not necessarily create a new BFC raised issues, such as how nested
line-clamps should work, or how floats inside a line-clamp container
should affect floats outside it. These problems go away by having
line-clamp create a new BFC, and this CL takes that route.

This patch also removes
BlockLineClampData::is_original_line_clamp_context, which was needed
to be able to distinguish whether (-webkit-)line-clamp was specified
on the current block element, or whether it inherited its line clamp
data from its parent. With this change, checking if the current block
is a new BFC is enough.

Bug: 40336192
Change-Id: I8a16ec18ce1653caaf1c7d06280a2a7e4604a946
Reviewed-on: https://chromium-review.googlesource.com/5453431
WPT-Export-Revision: 336414e0cc3672fae36bae912c1d062bb5bb7508

PR 45709 applied with additional changes from upstream: 9f53d39bcef48bdd862491409d1bcd3b8addd10b
Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

FAIL: 4

Safari

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6be13d29c793 [wpt PR 45709] - [line-clamp] Make `line-clamp` create a new BFC, a=testonly

https://hg.mozilla.org/mozilla-central/rev/6be13d29c793

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.