Update libvpx to new version 85dafa9c61f99330f484e77297684b42af6ff37d
Categories
(Core :: Audio/Video, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: update-bot, Assigned: chunmin)
Details
(Whiteboard: [3pl-filed][task_id: fYmt3Lk_SSm-0ChT4jJAEA])
Attachments
(4 files)
This update covers 49 commits. Here are the overall diff statistics, and then the commit information.
media/libvpx/config/generic/vpx_config.c | 2 +-
media/libvpx/config/linux/arm/vpx_config.c | 2 +-
media/libvpx/config/linux/arm64/vpx_config.c | 2 +-
media/libvpx/config/linux/ia32/vpx_config.c | 2 +-
media/libvpx/config/linux/x64/vpx_config.c | 2 +-
media/libvpx/config/mac/ia32/vpx_config.c | 2 +-
media/libvpx/config/mac/x64/vpx_config.c | 2 +-
media/libvpx/config/win/aarch64/vpx_config.c | 2 +-
media/libvpx/config/win/ia32/vpx_config.c | 2 +-
media/libvpx/config/win/x64/vpx_config.c | 2 +-
media/libvpx/libvpx/build/make/rtcd.pl | 4 +
media/libvpx/libvpx/test/add_noise_test.cc | 1 +
media/libvpx/libvpx/test/altref_test.cc | 1 +
media/libvpx/libvpx/test/bench.cc | 1 +
media/libvpx/libvpx/test/borders_test.cc | 6 +
media/libvpx/libvpx/test/comp_avg_pred_test.cc | 1 +
media/libvpx/libvpx/test/convolve_test.cc | 22 +-
media/libvpx/libvpx/test/cpu_speed_test.cc | 5 +-
media/libvpx/libvpx/test/cq_test.cc | 6 +
media/libvpx/libvpx/test/dct16x16_test.cc | 1 +
media/libvpx/libvpx/test/dct_partial_test.cc | 1 +
media/libvpx/libvpx/test/dct_test.cc | 1 +
media/libvpx/libvpx/test/decode_corrupted.cc | 1 +
media/libvpx/libvpx/test/encode_api_test.cc | 154 +++++-
media/libvpx/libvpx/test/encode_test_driver.h | 11 +-
media/libvpx/libvpx/test/error_resilience_test.cc | 6 +
media/libvpx/libvpx/test/fdct8x8_test.cc | 1 +
media/libvpx/libvpx/test/frame_size_tests.cc | 13 +
media/libvpx/libvpx/test/hadamard_test.cc | 1 +
media/libvpx/libvpx/test/level_test.cc | 17 +-
media/libvpx/libvpx/test/minmax_test.cc | 1 +
media/libvpx/libvpx/test/partial_idct_test.cc | 1 +
media/libvpx/libvpx/test/realtime_test.cc | 5 +
media/libvpx/libvpx/test/resize_test.cc | 1 +
media/libvpx/libvpx/test/test.mk | 9 +
media/libvpx/libvpx/test/test_vectors.cc | 1 +
media/libvpx/libvpx/test/timestamp_test.cc | 8 +
media/libvpx/libvpx/test/vp8_denoiser_sse2_test.cc | 1 +
media/libvpx/libvpx/test/vp9_arf_freq_test.cc | 1 +
media/libvpx/libvpx/test/vp9_boolcoder_test.cc | 25 +-
media/libvpx/libvpx/test/vp9_denoiser_test.cc | 1 +
media/libvpx/libvpx/test/vp9_end_to_end_test.cc | 3 +
media/libvpx/libvpx/test/vp9_ethread_test.cc | 23 +-
media/libvpx/libvpx/test/vp9_ext_ratectrl_test.cc | 20 +
media/libvpx/libvpx/test/vp9_lossless_test.cc | 5 +
media/libvpx/libvpx/test/vp9_motion_vector_test.cc | 3 +
media/libvpx/libvpx/test/vpx_image_test.cc | 127 ++++
media/libvpx/libvpx/test/yuv_temporal_filter_test.cc | 1 +
media/libvpx/libvpx/vp8/common/generic/systemdependent.c | 15 -
media/libvpx/libvpx/vp8/common/onyxc_int.h | 1 -
media/libvpx/libvpx/vp8/encoder/bitstream.c | 8 +-
media/libvpx/libvpx/vp8/encoder/encodeframe.c | 3 -
media/libvpx/libvpx/vp8/vp8_cx_iface.c | 21 +-
media/libvpx/libvpx/vp9/decoder/vp9_decodeframe.c | 1 +
media/libvpx/libvpx/vp9/encoder/vp9_bitstream.c | 125 +++-
media/libvpx/libvpx/vp9/encoder/vp9_bitstream.h | 5 +-
media/libvpx/libvpx/vp9/encoder/vp9_encodeframe.c | 11 +-
media/libvpx/libvpx/vp9/encoder/vp9_encoder.c | 58 +-
media/libvpx/libvpx/vp9/encoder/vp9_encoder.h | 8 +-
media/libvpx/libvpx/vp9/encoder/vp9_ethread.h | 1 +
media/libvpx/libvpx/vp9/encoder/vp9_firstpass.c | 40 +-
media/libvpx/libvpx/vp9/encoder/vp9_multi_thread.c | 29 +-
media/libvpx/libvpx/vp9/encoder/vp9_pickmode.c | 2 +-
media/libvpx/libvpx/vp9/encoder/vp9_rdopt.c | 4 +-
media/libvpx/libvpx/vp9/encoder/vp9_speed_features.h | 2 +-
media/libvpx/libvpx/vp9/ratectrl_rtc.cc | 4 +-
media/libvpx/libvpx/vp9/simple_encode.cc | 13 +-
media/libvpx/libvpx/vp9/simple_encode.h | 1 +
media/libvpx/libvpx/vp9/vp9_cx_iface.c | 39 +-
media/libvpx/libvpx/vpx/exports_com | 3 -
media/libvpx/libvpx/vpx/src/vpx_image.c | 83 +-
media/libvpx/libvpx/vpx/src/vpx_tpl.c | 107 ---
media/libvpx/libvpx/vpx/vpx_codec.mk | 1 -
media/libvpx/libvpx/vpx/vpx_encoder.h | 2 +
media/libvpx/libvpx/vpx/vpx_ext_ratectrl.h | 113 +--
media/libvpx/libvpx/vpx/vpx_image.h | 26 +-
media/libvpx/libvpx/vpx/vpx_tpl.h | 38 +-
media/libvpx/libvpx/vpx_dsp/arm/highbd_convolve8_neon.h | 46 +
media/libvpx/libvpx/vpx_dsp/arm/highbd_convolve8_sve.h | 99 +++
media/libvpx/libvpx/vpx_dsp/arm/highbd_vpx_convolve8_neon.c | 127 +--
media/libvpx/libvpx/vpx_dsp/arm/highbd_vpx_convolve8_sve.c | 98 +---
media/libvpx/libvpx/vpx_dsp/arm/highbd_vpx_convolve8_sve2.c | 336 ++++++++++++
media/libvpx/libvpx/vpx_dsp/arm/vpx_scaled_convolve8_neon.c | 1 +
media/libvpx/libvpx/vpx_dsp/bitwriter.c | 21 +-
media/libvpx/libvpx/vpx_dsp/bitwriter.h | 34 +-
media/libvpx/libvpx/vpx_dsp/bitwriter_buffer.c | 21 +-
media/libvpx/libvpx/vpx_dsp/bitwriter_buffer.h | 16 +-
media/libvpx/libvpx/vpx_dsp/vpx_dsp_rtcd_defs.pl | 4 +-
media/libvpx/libvpx/vpx_ports/aarch64_cpudetect.c | 7 +-
media/libvpx/libvpx/vpx_util/vpx_thread.h | 2 -
media/libvpx/moz.yaml | 4 +-
media/libvpx/sources.mozbuild | 5 -
92 files changed, 1450 insertions(+), 645 deletions(-)
976134c50d1f9d67c582c4e35805121117b0f178 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/976134c50d1f9d67c582c4e35805121117b0f178
Authored: 2024-04-12 14:06:40 -0700
Committed: 2024-04-13 03:20:57 +0000
Add 10 and 12b ranges to vpx_color_range_t comment
Add note about undefined behavior in vpx_codec_encode() description.
A port of the libaom CL
https://aomedia-review.googlesource.com/c/aom/+/158001
by Yannis Guyon <yguyon@google.com>.
Bug: webm:1850
Change-Id: Ia90f0bfd8265e35e9f33c17400c1c065d7915b77
Files Modified:
- vpx/vpx_encoder.h
- vpx/vpx_image.h
89efe85cd48055ffd027f6bab6490dc639e19009 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/89efe85cd48055ffd027f6bab6490dc639e19009
Authored: 2024-04-12 14:36:40 -0700
Committed: 2024-04-13 03:19:57 +0000
Clarify comment about buf_align in vpx_img_wrap.
If img_data is not NULL, img_alloc_helper ignores buf_align, so
vpx_img_wrap can set buf_align to any placeholder value.
A port of the libaom CL
https://aomedia-review.googlesource.com/c/aom/+/90362.
Bug: webm:1850
Change-Id: I42bc45aecf822a9314caf23058fe123d0574dc20
Files Modified:
- vpx/src/vpx_image.c
3f4055b05b6eb7a4f434b658ef1736602aa3bf61 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/3f4055b05b6eb7a4f434b658ef1736602aa3bf61
Authored: 2024-04-12 14:44:23 -0700
Committed: 2024-04-13 03:19:00 +0000
Introduce local vars uv_x,uv_y in vpx_img_set_rect
Port the changes to aom/src/aom_image.c in the libaom CL
https://aomedia-review.googlesource.com/c/aom/+/56643. The changes
related to border are not ported.
Bug: webm:1850
Change-Id: Ie81fffe0c84e912da880ffca245ae27cd71cf348
Files Modified:
- vpx/src/vpx_image.c
74c70af01667733483dc69298b8921779f5f6ff3 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/74c70af01667733483dc69298b8921779f5f6ff3
Authored: 2024-04-12 15:48:04 -0700
Committed: 2024-04-12 15:48:04 -0700
Fix a bug in alloc_size for high bit depths
I introduced this bug in commit 2e32276:
https://chromium-review.googlesource.com/c/webm/libvpx/+/5446333
I changed the line
stride_in_bytes = (fmt & VPX_IMG_FMT_HIGHBITDEPTH) ? s * 2 : s;
to three lines:
s = (fmt & VPX_IMG_FMT_HIGHBITDEPTH) ? s * 2 : s;
if (s > INT_MAX) goto fail;
stride_in_bytes = (int)s;
But I didn't realize that s is used later in the calculation of
alloc_size.
As a quick fix, undo the effect of s * 2 for high bit depths after s
has been assigned to stride_in_bytes.
Bug: chromium:332382766
Change-Id: I53fbf405555645ab1d7254d31aadabe4f426be8c
Files Modified:
- vpx/src/vpx_image.c
7d37ffacc6f7c45554b48ca867be4223248f1ed6 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/7d37ffacc6f7c45554b48ca867be4223248f1ed6
Authored: 2024-04-11 16:38:45 -0700
Committed: 2024-04-11 16:46:13 -0700
Apply stride_align to byte count, not pixel count
A port of the libaom CL
https://aomedia-review.googlesource.com/c/aom/+/188962.
stride_align is documented to be the "alignment, in bytes, of each row
in the image (stride)."
Change-Id: I2184b50dc3607611f47719319fa5adb3adcef2fd
Files Modified:
- vpx/src/vpx_image.c
- vpx/vpx_image.h
8b2f8baee5acdc579b90a72e6ea787d4103b462e by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/8b2f8baee5acdc579b90a72e6ea787d4103b462e
Authored: 2024-04-11 15:51:40 -0700
Committed: 2024-04-11 15:59:44 -0700
Avoid wasted calc of stride_in_bytes if !img_data
Change-Id: If1ddde5e894a06359f15486a2cee054a2f0cb1a2
Files Modified:
- vpx/src/vpx_image.c
06af417e795e6a9b9309406ba399fb109def89e6 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/06af417e795e6a9b9309406ba399fb109def89e6
Authored: 2024-04-11 10:24:11 -0700
Committed: 2024-04-11 10:29:38 -0700
Avoid integer overflows in arithmetic operations
A port of the libaom CL
https://aomedia-review.googlesource.com/c/aom/+/188823.
Impose maximum values on the input parameters so that we can perform
arithmetic operations without worrying about overflows.
Also change the VpxImageTest.VpxImgAllocHugeWidth test to write to the
first and last samples in the first row of the Y plane, so that the test
will crash if there is unsigned integer overflow in the calculation of
stride_in_bytes.
Bug: chromium:332382766
Change-Id: I54cec6c9e26377abaa8a991042ba277ff70afdf3
Files Modified:
- test/vpx_image_test.cc
- vpx/src/vpx_image.c
- vpx/vpx_image.h
2e32276277c0b1739707c5e861c96cf78794f1a0 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/2e32276277c0b1739707c5e861c96cf78794f1a0
Authored: 2024-04-10 17:01:10 -0700
Committed: 2024-04-10 20:47:45 -0700
Fix integer overflows in calc of stride_in_bytes
A port of the libaom CL
https://aomedia-review.googlesource.com/c/aom/+/188761.
Fix unsigned integer overflows in the calculation of stride_in_bytes in
img_alloc_helper() when d_w is huge.
Change the type of stride_in_bytes from unsigned int to int because it
will be assigned to img->stride[VPX_PLANE_Y], which is of the int type.
Test:
. ../libvpx/tools/set_analyzer_env.sh integer
../libvpx/configure --enable-debug --disable-optimizations
make -j
./test_libvpx --gtest_filter=VpxImageTest.VpxImgAllocHugeWidth
Bug: chromium:332382766
Change-Id: I3b39d78f61c7255e10cbf72ba2f4975425a05a82
Files Modified:
- test/vpx_image_test.cc
- vpx/src/vpx_image.c
3dbab0e66479e1b5368d4b7a069051dba85843cf by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/3dbab0e66479e1b5368d4b7a069051dba85843cf
Authored: 2024-04-10 17:55:01 -0700
Committed: 2024-04-10 18:15:00 -0700
Add test/vpx_image_test.cc
Ported from test/aom_image_test.cc in libaom commit 04d6253.
Change-Id: I56478d0a5603cfb5b65e644add0918387ff69a00
Files Added:
- test/vpx_image_test.cc
Files Modified:
- test/test.mk
8762f5efb2917765316a198e6713f0bc93b07c9b by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/8762f5efb2917765316a198e6713f0bc93b07c9b
Authored: 2024-02-15 14:44:01 -0800
Committed: 2024-04-04 20:27:32 +0000
Define the MAX_NUM_THREADS macro in vp9_ethread.h
The MAX_NUM_THREADS macro is unrelated to the VPxWorkerInterface, so it
doesn't need to be defined in vpx_util/vpx_thread.h.
The VP8 code doesn't seem to depend on MAX_NUM_THREADS, so VP8 can use
64 directly in the range check of its g_threads option. Move the
definition of the MAX_NUM_THREADS macro to vp9/encoder/vp9_ethread.h and
use it in VP9 code only.
Change-Id: Ibf788ca2496c743a2ac0498fefaab8a3c181228d
Files Modified:
- vp8/vp8_cx_iface.c
- vp9/encoder/vp9_ethread.h
- vp9/vp9_cx_iface.c
- vpx_util/vpx_thread.h
0752960c6a02e33a79c1e9bb6d518170281b022f by Chun-Min Chang
https://chromium.googlesource.com/webm/libvpx/+/0752960c6a02e33a79c1e9bb6d518170281b022f
Authored: 2024-04-04 09:52:11 -0700
Committed: 2024-04-04 10:10:37 -0700
Add missing header for EBUSY on mingw
The error: use of undeclared identifier 'EBUSY' in
vpx_util/vpx_pthread.h was found in Mozilla's bug 1886318 [1]. This
patch addresses the issue by adding the <errno.h> header to introduce
the EBUSY identifier, resolving the problem.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1886318#c1
Change-Id: Ic417dafebf5ab160060dd29f692fa9c40d8db05a
Files Modified:
- vpx_util/vpx_pthread.h
6445da1b40da7967ccaee23d1ac46d5c3981b89c by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/6445da1b40da7967ccaee23d1ac46d5c3981b89c
Authored: 2024-04-02 21:23:25 +0000
Committed: 2024-04-04 00:03:35 +0000
Fix GCC -Wmissing-braces warnings
warning: missing braces around initializer [-Wmissing-braces]
Bug: webm:1846
Change-Id: I007a68d09f48d4199ecd948136e69f9cf5f219f5
Files Modified:
- vp9/encoder/vp9_pickmode.c
- vp9/encoder/vp9_rdopt.c
2bafeadd3ebdcdd862fe7d5c763f8785d9579cfe by Casey Smalley
https://chromium.googlesource.com/webm/libvpx/+/2bafeadd3ebdcdd862fe7d5c763f8785d9579cfe
Authored: 2024-04-03 13:48:18 +0100
Committed: 2024-04-03 20:20:44 +0000
Add missing configuration includes
The Google cpp style guide dictates that you should "include what you
use" with respect to symbols. This CL adds vpx_config.h imports to unit
tests that rely on config flags but were otherwise indirectly included.
Change-Id: Ia70a512cebe6c104d2d64afbed3cde8a405c68df
Files Modified:
- test/add_noise_test.cc
- test/altref_test.cc
- test/borders_test.cc
- test/comp_avg_pred_test.cc
- test/cq_test.cc
- test/dct16x16_test.cc
- test/dct_partial_test.cc
- test/dct_test.cc
- test/decode_corrupted.cc
- test/error_resilience_test.cc
- test/fdct8x8_test.cc
- test/frame_size_tests.cc
- test/hadamard_test.cc
- test/level_test.cc
- test/minmax_test.cc
- test/partial_idct_test.cc
- test/realtime_test.cc
- test/resize_test.cc
- test/test_vectors.cc
- test/timestamp_test.cc
- test/vp8_denoiser_sse2_test.cc
- test/vp9_arf_freq_test.cc
- test/vp9_denoiser_test.cc
- test/vp9_end_to_end_test.cc
- test/vp9_ethread_test.cc
- test/vp9_motion_vector_test.cc
- test/yuv_temporal_filter_test.cc
588beb020ba0e4b0ea3551b3861ce4d599e00adc by Casey Smalley
https://chromium.googlesource.com/webm/libvpx/+/588beb020ba0e4b0ea3551b3861ce4d599e00adc
Authored: 2024-01-23 16:51:47 +0000
Committed: 2024-04-03 20:20:44 +0000
Unit test config changes for Chromium
This CL will help run libvpx tests under Chromium against its partition
allocator. The allocator does not support single allocations above
3.998GiB. Because of this tests related to large video sizes that
Chromium is configured for are expected to fail.
Chromium also only supports the CONFIG_REALTIME_ONLY option,
some changes are scoped behind this flag.
Change-Id: I80e8743c0619ce502688109ce0be01cb252d5f92
Files Modified:
- test/bench.cc
- test/borders_test.cc
- test/cpu_speed_test.cc
- test/cq_test.cc
- test/encode_api_test.cc
- test/encode_test_driver.h
- test/error_resilience_test.cc
- test/frame_size_tests.cc
- test/level_test.cc
- test/realtime_test.cc
- test/test.mk
- test/timestamp_test.cc
- test/vp9_end_to_end_test.cc
- test/vp9_ethread_test.cc
- test/vp9_ext_ratectrl_test.cc
- test/vp9_lossless_test.cc
- test/vp9_motion_vector_test.cc
05a4c855be2e5374f22b65c3cb7403416ffa4ec8 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/05a4c855be2e5374f22b65c3cb7403416ffa4ec8
Authored: 2024-04-02 21:54:56 +0000
Committed: 2024-04-03 02:53:45 +0000
Compare ctx->pending_cx_data with NULL
ctx->pending_cx_data is a pointer. It looks nicer to compare
ctx->pending_cx_data with NULL than with 0.
Change-Id: I18815907b3d75551abfc603cb3c5c0297dceed23
Files Modified:
- vp9/vp9_cx_iface.c
1d007eafa346afe80b4e90b5906d97128d2f7292 by Hirokazu Honda
https://chromium.googlesource.com/webm/libvpx/+/1d007eafa346afe80b4e90b5906d97128d2f7292
Authored: 2024-04-03 07:40:32 +0900
Committed: 2024-04-02 23:00:50 +0000
vp9 rc: Fix GetSegmentationData() crash in aq_mode=0
cpi_->cyclic_refresh is nullptr if aq_mode is 0, in other words, the
rate controller runs in non adaptive quantization mode. This CL fixes
the crash in GetSegmentationData() in non aq mode.
Bug: b/259487065
Test: video encoding on ChromeOS
Change-Id: I503b30d15c697c8dd1da203b3c7361b91c428e87
Files Modified:
- vp9/ratectrl_rtc.cc
976cedd6437dc1555d7c6ef10457a7d468968e36 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/976cedd6437dc1555d7c6ef10457a7d468968e36
Authored: 2024-04-02 21:09:55 +0000
Committed: 2024-04-02 22:53:17 +0000
Set priv->cx_data_sz to 0 if cx_data alloc fails
Change-Id: I6553cd7b09270b4d60ccd7199d499e03c22b3936
Files Modified:
- vp8/vp8_cx_iface.c
419f36e8edfb9b0d0c00fb4fb2bde6d1cd1e1340 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/419f36e8edfb9b0d0c00fb4fb2bde6d1cd1e1340
Authored: 2024-03-28 12:32:36 -0700
Committed: 2024-04-02 21:52:03 +0000
encoder_encode: Assert pending_cx_data_sz is valid
In encoder_encode(), assert ctx->pending_cx_data_sz is not too big
before the memmove() call.
Change-Id: Icd1e95f6d751b0bf67386d0d99218b256bc91ebd
Files Modified:
- vp9/vp9_cx_iface.c
dc74cf923b29c2b513770877e8d15dc5f22a4c57 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/dc74cf923b29c2b513770877e8d15dc5f22a4c57
Authored: 2024-03-28 12:24:24 -0700
Committed: 2024-04-02 17:56:48 +0000
Dont use VPX_CODEC_CORRUPT_FRAME in set_frame_size
VPX_CODEC_CORRUPT_FRAME is a decoder error. It is strange for
vpx_codec_encode() to fail with this error. In set_frame_size(), change
VPX_CODEC_CORRUPT_FRAME to VPX_CODEC_ERROR.
The use of VPX_CODEC_CORRUPT_FRAME was originally added in
commit 1ed56a46b3.
Change-Id: Iee92ed4cfca5061289b278ece2ba475cf98fec06
Files Modified:
- vp9/encoder/vp9_encoder.c
bf932674a83f52e407f7c2a738fc08550f13711c by Gerda Zsejke More
https://chromium.googlesource.com/webm/libvpx/+/bf932674a83f52e407f7c2a738fc08550f13711c
Authored: 2024-03-19 22:19:39 +0100
Committed: 2024-04-02 13:32:51 +0200
Add SVE2 implementation of vpx_highbd_convolve8_avg
Add SVE2 implementation of vpx_highbd_convolve8_avg function and the
corresponding tests as well.
Change-Id: I2ff707da55d11b1d5376eb0a7ec85c343a2709c2
Files Modified:
- test/convolve_test.cc
- vpx_dsp/arm/highbd_vpx_convolve8_sve2.c
- vpx_dsp/vpx_dsp_rtcd_defs.pl
9274c2bbf06f405d4e04835288e8f1c3ecb0e7da by Gerda Zsejke More
https://chromium.googlesource.com/webm/libvpx/+/9274c2bbf06f405d4e04835288e8f1c3ecb0e7da
Authored: 2024-03-17 16:19:45 +0100
Committed: 2024-04-02 13:29:48 +0200
Merge horiz. and vert. passes in HBD SVE2 2D 4tap convolution
The current SVE2 approach to 2D convolution is:
- Filter horizontally, storing to an intermediate buffer.
- Filter vertically and store the final output.
This patch merges the two phases for high bitdepth 2D convolution for
filter sizes smaller or equal to 4 to avoid the storing and
re-loading from the intermediate buffer.
This approach is not beneficial when applying an 8tap filter in the
convolution.
Change-Id: Ie090eb79f1cbf182300d9343ae63069396ef3956
Files Added:
- vpx_dsp/arm/highbd_convolve8_neon.h
Files Modified:
- vpx_dsp/arm/highbd_convolve8_sve.h
- vpx_dsp/arm/highbd_vpx_convolve8_neon.c
- vpx_dsp/arm/highbd_vpx_convolve8_sve.c
- vpx_dsp/arm/highbd_vpx_convolve8_sve2.c
43d12d50799e437b9e862600ecab4d470b1b06e8 by Jingning Han
https://chromium.googlesource.com/webm/libvpx/+/43d12d50799e437b9e862600ecab4d470b1b06e8
Authored: 2024-03-29 11:33:23 -0700
Committed: 2024-03-30 00:02:02 +0000
Update yv12_mb initialization
BUG=webm:1846
Change-Id: If8475d46397f04ef769f3e4647de5c2d4b6760a4
Files Modified:
- vp9/encoder/vp9_pickmode.c
- vp9/encoder/vp9_rdopt.c
5396643be6e7aa8c652fb50a49b197e78457e524 by Jerome Jiang
https://chromium.googlesource.com/webm/libvpx/+/5396643be6e7aa8c652fb50a49b197e78457e524
Authored: 2024-03-28 20:36:14 -0400
Committed: 2024-03-29 21:20:42 +0000
Add invalid value to gop decision enums
These invalid value definitions are necessary to initialize
the gop decision in external RC so libvpx can tell which is populated
and which is not
Bug: b/329483680
Change-Id: I06bbb41fa59d0fb95296aebd0d05a703ec953b81
Files Modified:
- vpx/vpx_ext_ratectrl.h
5f5dfb3303e6a3584d888f240c882b88955ff7d2 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/5f5dfb3303e6a3584d888f240c882b88955ff7d2
Authored: 2024-03-28 14:15:00 -0700
Committed: 2024-03-29 11:22:41 -0700
Assert the return value of read_tx_mode() is < 5
Coverity somehow thinks the return value of read_tx_mode() is between 0
and 7 (inclusive).
Hopefully this will fix Coverity CID 1584457: Out-of-bounds access in
read_coef_probs().
Change-Id: I49fbddf6fd6861bc9def9dfa91eaaaa4aefe5710
Files Modified:
- vp9/decoder/vp9_decodeframe.c
ccefddef33a0d8c7d9101b7c01e4b6259858ae6a by Jingning Han
https://chromium.googlesource.com/webm/libvpx/+/ccefddef33a0d8c7d9101b7c01e4b6259858ae6a
Authored: 2024-03-29 09:10:23 -0700
Committed: 2024-03-29 09:10:23 -0700
Initialize yv12_mb array
This array will be partially configured and used in later rate
distortion optimization search.
BUG=webm:1846
Change-Id: I83daba341c56767187031edb1c10d4528a4257a3
Files Modified:
- vp9/encoder/vp9_rdopt.c
d790001fd56edbc39482d596868ed83ee7355368 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/d790001fd56edbc39482d596868ed83ee7355368
Authored: 2024-03-27 17:08:08 -0700
Committed: 2024-03-28 14:05:47 -0700
Perform bounds checks in vpx_write_bit_buffer
Add the size and error members to the vpx_write_bit_buffer struct.
Add the vpx_wb_init() and vpx_wb_has_error() functions.
Instances of the vpx_write_bit_buffer struct are only allocated in the
vp9_pack_bitstream() function. So vp9_pack_bitstream() is the only
function outside vpx_dsp/bitwriter_buffer.* that needs updating.
This CL completes the work of adding output buffer bounds checks to
vp9/encoder/vp9_bitstream.c.
Bug: webm:1844
Change-Id: I6b362be572852ee51d96023b35bfb334faada7e1
Files Modified:
- vp9/encoder/vp9_bitstream.c
- vpx_dsp/bitwriter_buffer.c
- vpx_dsp/bitwriter_buffer.h
d5501945fc90438fe48df9a850f3ed58c7b5c51b by Jerome Jiang
https://chromium.googlesource.com/webm/libvpx/+/d5501945fc90438fe48df9a850f3ed58c7b5c51b
Authored: 2024-03-26 16:10:55 -0400
Committed: 2024-03-28 17:33:54 +0000
vp9 rc: override GF_GROUP decisions using ext RC
Bug: b/329483680
Change-Id: I2e02673f1bca56bfa24545b4e25d5e3fd3b0e863
Files Modified:
- test/vp9_ext_ratectrl_test.cc
- vp9/encoder/vp9_firstpass.c
3f8f19372b315f3d4d6342d77498293d5786de00 by Marco Paniconi
https://chromium.googlesource.com/webm/libvpx/+/3f8f19372b315f3d4d6342d77498293d5786de00
Authored: 2024-03-26 12:30:26 -0700
Committed: 2024-03-28 16:47:45 +0000
vp9: Fix to alloc for row_base_thresh_freq_fac
Issue happens for real-time nonrd pickmode.
Due to speed feature: sf->adaptive_rd_thresh_row_mt,
enabled for speed >= 8, and for speed >= 7 svc only.
Issue occurs where resolution (sb_rows) changes and
row_base_thresh_freq_fact needs to be re-allocated.
Fix is to add sb_rows to TileDataEnc and check for
re-alloc of row_base_thresh_freq_fac.
Bug: b:331108922
Change-Id: I1a1ca94c14f343200c180725e4cb8d91d3c55b83
Files Modified:
- test/encode_api_test.cc
- vp9/encoder/vp9_encodeframe.c
- vp9/encoder/vp9_encoder.h
- vp9/encoder/vp9_multi_thread.c
73703c188b81f41bae59a72c9c86f8383587e994 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/73703c188b81f41bae59a72c9c86f8383587e994
Authored: 2024-03-22 20:41:22 -0700
Committed: 2024-03-27 09:07:03 -0700
Perform bounds checks in vpx_writer
In the vpx_writer struct, change the buffer_end field to the size field.
Change vpx_stop_encode() to return true on success, false on failure
(output buffer full).
In write_compressed_header(), remove the assertion
assert(header_bc.pos <= 0xffff). The caller (vp9_pack_bitstream()) will
check that condition.
In vp9_pack_bitstream(), the variable "first_part_size" is renamed
"compressed_hdr_size".
Bug: webm:1844
Change-Id: I4ed6ab905a707ad44d875e53036d5a42523a65d0
Files Modified:
- test/vp9_boolcoder_test.cc
- vp9/encoder/vp9_bitstream.c
- vpx_dsp/bitwriter.c
- vpx_dsp/bitwriter.h
5bea4606dd239e872d328c61a2bfe88cf93a0dd3 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/5bea4606dd239e872d328c61a2bfe88cf93a0dd3
Authored: 2024-03-26 16:15:14 -0700
Committed: 2024-03-27 14:48:55 +0000
Fix a typo in comment: "it" -> "is"
Change-Id: I5d36c5198c67cbb2f424901ec045d0620fea2f04
Files Modified:
- vp9/encoder/vp9_speed_features.h
34277e53addcf1b5490764d19ea2a0fcdd324c14 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/34277e53addcf1b5490764d19ea2a0fcdd324c14
Authored: 2024-03-26 12:12:11 -0700
Committed: 2024-03-26 23:38:09 +0000
Free row mt memory before freeing cpi->tile_data
In vp9_init_tile_data(), call vp9_row_mt_mem_dealloc(cpi) to free the
row mt memory in cpi->tile_data before freeing cpi->tile_data.
Bug: b:331086799, b:331108729
Change-Id: Idc79984ce7e0110e6858139b2ed286492a2e8622
Files Modified:
- test/encode_api_test.cc
- vp9/encoder/vp9_encodeframe.c
- vp9/encoder/vp9_multi_thread.c
d2ba3a22b44d351ca49e7e3a7fe3901e0d475cb1 by Gerda Zsejke More
https://chromium.googlesource.com/webm/libvpx/+/d2ba3a22b44d351ca49e7e3a7fe3901e0d475cb1
Authored: 2024-03-21 14:32:34 +0100
Committed: 2024-03-26 19:00:26 +0000
Add 2D-specific highbd SVE2 horizontal convolution function
2D 8-tap convolution filtering is performed in two passes -
horizontal and vertical. The horizontal pass must produce enough
input data for the subsequent vertical pass - 3 rows above and 4 rows
below, in addition to the actual block height.
At present, all highbd SVE horizontal convolution algorithms process
4 rows at a time, but this means we end up doing at least 1 row too
much work in the 2D first pass case where we need h + 7, not h + 8
rows of output.
This patch adds an additional SVE2 path that processes h + 7 rows of
data exactly, saving the work of the unnecessary extra row.
Change-Id: I2f5d39ad737dbd7eccb08dd2b51586c6710119b8
Files Added:
- vpx_dsp/arm/highbd_convolve8_sve.h
Files Modified:
- vpx_dsp/arm/highbd_vpx_convolve8_sve.c
- vpx_dsp/arm/highbd_vpx_convolve8_sve2.c
cd9d72c065a1cd6528c263b38de786ba48aecb50 by Gerda Zsejke More
https://chromium.googlesource.com/webm/libvpx/+/cd9d72c065a1cd6528c263b38de786ba48aecb50
Authored: 2024-03-10 19:33:46 +0100
Committed: 2024-03-26 19:00:26 +0000
Add SVE2 implementation of vpx_highbd_convolve8
Add SVE2 implementation of vpx_highbd_convolve8 function. Add the
corresponding tests as well.
Change-Id: I783cc083f1bce5f13ce721bc191b34c48033f5ae
Files Modified:
- test/convolve_test.cc
- vpx_dsp/arm/highbd_vpx_convolve8_sve2.c
- vpx_dsp/vpx_dsp_rtcd_defs.pl
c9bd57353178aeb5e733d9ac695b4890e6e557ef by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/c9bd57353178aeb5e733d9ac695b4890e6e557ef
Authored: 2024-03-25 14:46:50 -0700
Committed: 2024-03-25 14:46:50 -0700
Replace "cpi->common." with "pc->"
If a local variable "pc" is defined as &cpi->common, replace
"cpi->common." with "pc->".
Also replace a memcpy() call with a struct assignment.
Change-Id: I6f4f12e69d9989beaa6e04c83d93230e7d726278
Files Modified:
- vp8/encoder/bitstream.c
4f579df337ac46f70bd684f3b397695bac7961e0 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/4f579df337ac46f70bd684f3b397695bac7961e0
Authored: 2024-03-23 11:20:22 -0700
Committed: 2024-03-23 11:20:22 -0700
Declare VP9BitstreamWorkerData dest_size as size_t
Declare the dest_size member of the VP9BitstreamWorkerData struct as
size_t instead of int.
Fix the following MSVC warning:
vp9\encoder\vp9_bitstream.c(1031,37): warning C4267: '=':
conversion from 'size_t' to 'int', possible loss of data
Change-Id: Idab5ad5d4bf4d1e4754f011a3073c9a89da29f55
Files Modified:
- vp9/encoder/vp9_bitstream.c
- vp9/encoder/vp9_bitstream.h
e3871874386985325676426451869aa401fefa28 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/e3871874386985325676426451869aa401fefa28
Authored: 2024-03-21 15:13:02 -0700
Committed: 2024-03-23 02:15:42 +0000
Add the buffer_end field to the vpx_writer struct
The buffer_end field will allow bounds checking when vpx_writer writes
to the output buffer. This CL sets up the plumbing to pass the output
buffer size from vp9_pack_bitstream() to vpx_start_encode(), which
initializes the vpx_writer struct. vpx_writer doesn't use the output
buffer size in bounds checks yet, but the code in vp9_bitstream.c does.
Bug: webm:1844
Change-Id: I995e469ab453c02d740f54b46e0b08c7f2eb1a2e
Files Modified:
- test/vp9_boolcoder_test.cc
- vp9/encoder/vp9_bitstream.c
- vpx_dsp/bitwriter.c
- vpx_dsp/bitwriter.h
9137f7fa4bcd55574ecca156d91586ed6b053e94 by James Zern
https://chromium.googlesource.com/webm/libvpx/+/9137f7fa4bcd55574ecca156d91586ed6b053e94
Authored: 2024-03-22 09:45:42 -0700
Committed: 2024-03-22 09:45:42 -0700
rtcd.pl: add empty specialize() check
This was added in libaom in:
5ddac0aac8 RTCD defs: Remove empty specialize statements once and for all.
https://aomedia-review.googlesource.com/c/aom/+/9062
Change-Id: I9c8fb0c8e4bd4dc9373d8533ab083dff816e7cbe
Files Modified:
- build/make/rtcd.pl
d48577579bd009e0a6c3145ea528a42d70560d95 by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/d48577579bd009e0a6c3145ea528a42d70560d95
Authored: 2024-03-21 15:44:41 -0700
Committed: 2024-03-21 18:59:58 -0700
Pass output buffer size to vp9_pack_bitstream()
Set up the plumbing to pass the size of the output buffer dest to
vp9_pack_bitstream(). The output buffer is the cx_data buffer in the
encoder_encode() function in vp9/vp9_cx_iface.c, and its size is
cx_data_sz.
In this CL vp9_pack_bitstream() ignores the dest_size parameter.
Bug: webm:1844
Change-Id: I53c80280143d409cf16f87c4d6deec3d9338aea3
Files Modified:
- vp9/encoder/vp9_bitstream.c
- vp9/encoder/vp9_bitstream.h
- vp9/encoder/vp9_encoder.c
- vp9/encoder/vp9_encoder.h
- vp9/simple_encode.cc
- vp9/simple_encode.h
- vp9/vp9_cx_iface.c
cab4f31e1d474c75c1dfd54312d0e9d9c16f4839 by James Zern
https://chromium.googlesource.com/webm/libvpx/+/cab4f31e1d474c75c1dfd54312d0e9d9c16f4839
Authored: 2024-03-15 13:41:32 -0700
Committed: 2024-03-21 01:59:48 +0000
encodeframe.c: remove some unused includes
clears some clang-tidy warnings
Change-Id: I82c1d212126b9c7b010b6bc8ac32d92453f6d376
Files Modified:
- vp8/encoder/encodeframe.c
3c58cb1bc212437f8a5941714ef205e5715cec92 by James Zern
https://chromium.googlesource.com/webm/libvpx/+/3c58cb1bc212437f8a5941714ef205e5715cec92
Authored: 2024-03-20 13:14:35 -0700
Committed: 2024-03-20 13:14:35 -0700
VP8_COMMON: remove unused cpu_caps member
This was set, but not read; rtcd covers this.
Change-Id: I1d8b8f8d8ed9e7bc56c3734cb96b79b937b5e20c
Files Modified:
- vp8/common/generic/systemdependent.c
- vp8/common/onyxc_int.h
6e879c6173cc370f0e281247d634a75ce419729f by Wan-Teh Chang
https://chromium.googlesource.com/webm/libvpx/+/6e879c6173cc370f0e281247d634a75ce419729f
Authored: 2024-03-19 11:10:51 -0700
Committed: 2024-03-20 20:03:57 +0000
Save encode_tiles_buffer_alloc_size() result
Avoid calling encode_tiles_buffer_alloc_size() twice by saving its
return value in a local variable.
Change-Id: I3050f9cf7c3520f7edc80abf66620ba233fadad8
Files Modified:
- vp9/encoder/vp9_bitstream.c
afc8b452b8de64a14b9de3a17c2011306a9c6a5f by James Zern
https://chromium.googlesource.com/webm/libvpx/+/afc8b452b8de64a14b9de3a17c2011306a9c6a5f
Authored: 2024-03-15 13:38:41 -0700
Committed: 2024-03-20 18:24:37 +0000
aarch64_cpudetect: add missing include
clears clang-tidy warning for HAS_*
Change-Id: I1b21326480b7c5c3be18c055f848071df0076915
Files Modified:
- vpx_ports/aarch64_cpudetect.c
55d4b736b2ac2c58886399980b8cf0d95608667c by James Zern
https://chromium.googlesource.com/webm/libvpx/+/55d4b736b2ac2c58886399980b8cf0d95608667c
Authored: 2024-03-15 13:38:08 -0700
Committed: 2024-03-20 18:24:37 +0000
vpx_scaled_convolve8_neon: add missing include
clears clang-tidy warnings for types and constants in vpx_filter.h
Change-Id: I1f3f843b9ab6fd0ad038e33a048e8708cbd2a950
Files Modified:
- vpx_dsp/arm/vpx_scaled_convolve8_neon.c
6358ef62611a12865d39baed4a35bce97df5835d by Jerome Jiang
https://chromium.googlesource.com/webm/libvpx/+/6358ef62611a12865d39baed4a35bce97df5835d
Authored: 2024-03-20 10:46:34 -0400
Committed: 2024-03-20 12:17:52 -0400
vp9 rc: Add ref frame list for each frame in GOP
Bug: b/329483680
Change-Id: I24573c25e70b41b7af243c473f28fa1b290cc373
Files Modified:
- vpx/vpx_ext_ratectrl.h
18059190d78a628bf70fb7730e5dc93f3d7637ff by Jerome Jiang
https://chromium.googlesource.com/webm/libvpx/+/18059190d78a628bf70fb7730e5dc93f3d7637ff
Authored: 2024-03-20 10:31:07 -0400
Committed: 2024-03-20 16:17:23 +0000
Remove vpx_rc_gop_info_t
Not being used anywhere any more. This was used to pass
GOP info to ML models.
Bug: b/617172914
Change-Id: Ibcfa00bc8215b73f43d9a11edbe00b6a2d7fb137
Files Modified:
- vpx/vpx_ext_ratectrl.h
6641e9e03c6ee96552957c01f416f4e1863c34cb by Jerome Jiang
https://chromium.googlesource.com/webm/libvpx/+/6641e9e03c6ee96552957c01f416f4e1863c34cb
Authored: 2024-03-18 21:32:36 -0400
Committed: 2024-03-20 16:17:23 +0000
Add update type and ref update idx to gop decision
Bug: b/329483680
Change-Id: Ifc82ad79415400bbec4efe6ab9b78496d5f73ee7
Files Modified:
- vpx/vpx_ext_ratectrl.h
458e1c6875e93eb29bca2548aff430c9db08ab10 by Jerome Jiang
https://chromium.googlesource.com/webm/libvpx/+/458e1c6875e93eb29bca2548aff430c9db08ab10
Authored: 2024-03-19 10:28:53 -0400
Committed: 2024-03-19 19:05:24 +0000
Remove TPL IO functions
These are not used in libvpx.
Bug: webm:1837
Change-Id: Ic234b2dcd47d6614030b8a066c921e4285af5e99
Files Deleted:
- vpx/src/vpx_tpl.c
Files Modified:
- vpx/exports_com
- vpx/vpx_codec.mk
- vpx/vpx_tpl.h
19832b1702d5b0adf616a0e080abd5207c8445b5 by Marco Paniconi
https://chromium.googlesource.com/webm/libvpx/+/19832b1702d5b0adf616a0e080abd5207c8445b5
Authored: 2024-03-16 10:39:28 -0700
Committed: 2024-03-17 10:07:34 -0700
vp9: fix to integer overflow test
failure for the 16k test: issue introduced
in: c29e637283
Bug: b/329088759, b/329674887, b/329179808
Change-Id: I88e8a36b7f13223997c3006c84aec9cfa48c0bcf
Files Modified:
- vp9/encoder/vp9_bitstream.c
c29e63728316486082dd6083c2062434b441b77d by Marco Paniconi
https://chromium.googlesource.com/webm/libvpx/+/c29e63728316486082dd6083c2062434b441b77d
Authored: 2024-03-13 10:58:17 -0700
Committed: 2024-03-15 21:43:28 +0000
Fix to buffer alloc for vp9_bitstream_worker_data
The code was using the bitstream_worker_data when it
wasn't allocated for big enough size. This is because
the existing condition was to only re-alloc the
bitstream_worker_data when current dest_size was larger
than the current frame_size. But under resolution change
where frame_size is increased, beyond the current dest_size,
we need to allow re-alloc to the new size.
The existing condition to re-alloc when dest_size is
larger than frame_size (which is not required) is kept
for now.
Also increase the dest_size to account for image format.
Added tests, for both ROW_MT=0 and 1, that reproduce
the failures in the bugs below.
Note: this issue only affects the REALTIME encoding path.
Bug: b/329088759, b/329674887, b/329179808
Change-Id: Icd65dbc5317120304d803f648d4bd9405710db6f
Files Modified:
- test/encode_api_test.cc
- vp9/encoder/vp9_bitstream.c
|
Reporter | |
Comment 1•11 months ago
|
||
| fYmt3Lk_SSm-0ChT4jJAEA | ||
Updatebot encountered an error while trying to apply the mozilla patches. with the following message:
stdout:
Importing local patches...
patch -p1 --directory media/libvpx/libvpx/ --input /builds/worker/checkouts/gecko/media/libvpx/arm_cpu_runtime_detection_code_on_openbsd.patch --no-backup-if-mismatch
patching file vpx_ports/aarch64_cpudetect.c
Hunk #1 FAILED at 10.
1 out of 1 hunk FAILED -- saving rejects to file vpx_ports/aarch64_cpudetect.c.rej
Error running mach:mach vendor --patch-mode only media/libvpx/moz.yamlThe error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke./mach bustedto check if this issue is already on file. If it
isn't, please use./mach busted file vendorto report it. If./mach bustedis
misbehaving, you can also inspect the dependencies of bug 1543241.If filing a bug, please include the full output of mach, including this error
message.The details of the failure are as follows:
Exception: Process executed with non-0 exit code 1: ['patch', '-p1', '--directory', 'media/libvpx/libvpx/', '--input', '/builds/worker/checkouts/gecko/media/libvpx/arm_cpu_runtime_detection_code_on_openbsd.patch', '--no-backup-if-mismatch']
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/mach_commands.py", line 130, in vendor
vendor_command.vendor(
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/vendor_manifest.py", line 132, in vendor
self.import_local_patches(
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/vendor_manifest.py", line 886, in import_local_patches
self.run_process(
File "/builds/worker/checkouts/gecko/python/mach/mach/mixin/process.py", line 196, in run_process
raise Exception(f"Process executed with non-0 exit code {status}: {args}")
Updatebot will be unable to do anything more for this library version.
|
Assignee | |
Comment 2•11 months ago
|
||
The missing_header patch has been uplifted and merged in the upstream
[1], so there is no need to patch it locally.
[1] https://chromium-review.googlesource.com/c/webm/libvpx/+/5425372
|
|
Assignee | |
Comment 3•11 months ago
|
||
This patch runs ./mach vendor media/libvpx/moz.yaml --patch-mode=none
to update libvpx to 85dafa9c61f99330f484e77297684b42af6ff37d.
Depends on D207805
|
|
Assignee | |
Comment 4•11 months ago
|
||
The aarch64_cpudetect.c has been updated by the previous patch.
Consequently, the arm-cpu-runtime-detection patch modifying this file
should also be adjusted accordingly.
Depends on D207806
|
|
Assignee | |
Comment 5•11 months ago
|
||
This patch runs ./mach vendor media/libvpx/moz.yaml --patch-mode=only
to apply local patches.
Depends on D207807
|
||
Updated•11 months ago
|
|
|
Assignee | |
Updated•11 months ago
|
|
|
Assignee | |
Updated•11 months ago
|
|
||
Comment 7•11 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/32141fd31fc4
https://hg.mozilla.org/mozilla-central/rev/8cd0edbd53e9
https://hg.mozilla.org/mozilla-central/rev/c51f43f44f41
https://hg.mozilla.org/mozilla-central/rev/e18b0019f9be
Description
•