1891462 - Update xsimd to new version 7eb009bca73e5cc51d05dcfcda25dfb74d6e0aaa from 2024-03-28 13:40:05

Status: RESOLVED FIXED

(Core :: Performance: General, enhancement)

Description

[Update Bot]

This update covers 4 commits. Here are the overall diff statistics, and then the commit information.

---

third_party/xsimd/include/xsimd/arch/generic/xsimd_generic_math.hpp | 2 +-
third_party/xsimd/include/xsimd/arch/generic/xsimd_generic_memory.hpp | 38 +-
third_party/xsimd/include/xsimd/arch/xsimd_avx.hpp | 38 +-
third_party/xsimd/include/xsimd/arch/xsimd_avx2.hpp | 20 +-
third_party/xsimd/include/xsimd/arch/xsimd_avx512bw.hpp | 16 +-
third_party/xsimd/include/xsimd/arch/xsimd_avx512f.hpp | 48 +-
third_party/xsimd/include/xsimd/arch/xsimd_emulated.hpp | 757 ++++++++++
third_party/xsimd/include/xsimd/arch/xsimd_isa.hpp | 4 +
third_party/xsimd/include/xsimd/arch/xsimd_neon.hpp | 8 +-
third_party/xsimd/include/xsimd/arch/xsimd_neon64.hpp | 70 +-
third_party/xsimd/include/xsimd/arch/xsimd_rvv.hpp | 12 +-
third_party/xsimd/include/xsimd/arch/xsimd_scalar.hpp | 92 +-
third_party/xsimd/include/xsimd/arch/xsimd_sse2.hpp | 97 +-
third_party/xsimd/include/xsimd/arch/xsimd_sse4_1.hpp | 14 +-
third_party/xsimd/include/xsimd/arch/xsimd_ssse3.hpp | 16 +-
third_party/xsimd/include/xsimd/arch/xsimd_sve.hpp | 12 +-
third_party/xsimd/include/xsimd/arch/xsimd_wasm.hpp | 32 +-
third_party/xsimd/include/xsimd/types/xsimd_all_registers.hpp | 4 +
third_party/xsimd/include/xsimd/types/xsimd_api.hpp | 29 +-
third_party/xsimd/include/xsimd/types/xsimd_batch_constant.hpp | 122 +-
third_party/xsimd/include/xsimd/types/xsimd_emulated_register.hpp | 80 +
third_party/xsimd/moz.yaml | 4 +-
22 files changed, 1207 insertions(+), 308 deletions(-)

---

7eb009bca73e5cc51d05dcfcda25dfb74d6e0aaa by serge-sans-paille

https://github.com/QuantStack/xsimd/commit/7eb009bca73e5cc51d05dcfcda25dfb74d6e0aaa
Authored: 2024-03-26 17:59:18 +0100
Committed: 2024-03-28 13:40:05 +0000

Provide and extra as_batch() method for batch_constant and as_bool_batch() batch_bool_constant

They come in addition to the implicit conversion operator which is
cumbersome to use.

Files Modified:

• include/xsimd/arch/xsimd_avx.hpp
• include/xsimd/arch/xsimd_avx2.hpp
• include/xsimd/arch/xsimd_avx512bw.hpp
• include/xsimd/arch/xsimd_avx512f.hpp
• include/xsimd/arch/xsimd_ssse3.hpp
• include/xsimd/arch/xsimd_sve.hpp
• include/xsimd/types/xsimd_batch_constant.hpp
• test/test_batch_constant.cpp

---

c63af923a4b14d63f6b2682f01200f7bda8cfc15 by serge-sans-paille

https://github.com/QuantStack/xsimd/commit/c63af923a4b14d63f6b2682f01200f7bda8cfc15
Authored: 2024-03-24 21:26:41 +0100
Committed: 2024-03-28 13:40:05 +0000

Harmonize constant batch type signature with non constant batch

batch<T, A> <> batch_constant<T, A, Csts...>
batch_bool<T, A> <> batch_bool_constant<T, A, Csts...>

This is a strong API (and ABI) change, but it makes the type system more
harmonious.

Files Modified:

• docs/source/api/batch_manip.rst
• include/xsimd/arch/generic/xsimd_generic_math.hpp
• include/xsimd/arch/generic/xsimd_generic_memory.hpp
• include/xsimd/arch/xsimd_avx.hpp
• include/xsimd/arch/xsimd_avx2.hpp
• include/xsimd/arch/xsimd_avx512bw.hpp
• include/xsimd/arch/xsimd_avx512f.hpp
• include/xsimd/arch/xsimd_emulated.hpp
• include/xsimd/arch/xsimd_neon.hpp
• include/xsimd/arch/xsimd_neon64.hpp
• include/xsimd/arch/xsimd_rvv.hpp
• include/xsimd/arch/xsimd_sse2.hpp
• include/xsimd/arch/xsimd_sse4_1.hpp
• include/xsimd/arch/xsimd_ssse3.hpp
• include/xsimd/arch/xsimd_sve.hpp
• include/xsimd/arch/xsimd_wasm.hpp
• include/xsimd/types/xsimd_api.hpp
• include/xsimd/types/xsimd_batch_constant.hpp
• test/test_batch_constant.cpp
• test/test_batch_manip.cpp
• test/test_select.cpp
• test/test_shuffle.cpp

---

86ceb6fd01d1548b47341babe30521e304777dde by serge-sans-paille

https://github.com/QuantStack/xsimd/commit/86ceb6fd01d1548b47341babe30521e304777dde
Authored: 2024-01-27 21:49:50 +0100
Committed: 2024-03-28 10:08:42 +0100

Add support form emulated<N> arch

As a side effect:

• provide a scalar version for xsimd::bitwise_cast.
• reorder some functions in xsimd_sse2.hpp

Fix #998

Files Added:

• .github/workflows/emulated.yml
• include/xsimd/arch/xsimd_emulated.hpp
• include/xsimd/types/xsimd_emulated_register.hpp

Files Modified:

• docs/source/api/arch.rst
• include/xsimd/arch/generic/xsimd_generic_memory.hpp
• include/xsimd/arch/xsimd_isa.hpp
• include/xsimd/arch/xsimd_scalar.hpp
• include/xsimd/arch/xsimd_sse2.hpp
• include/xsimd/types/xsimd_all_registers.hpp
• include/xsimd/types/xsimd_api.hpp
• test/test_arch.cpp
• test/test_batch_bool.cpp
• test/test_custom_default_arch.cpp
• test/test_memory.cpp
• test/test_xsimd_api.cpp

---

63ea057970e1c452334c8adf3d53f7f8a7f59ff2 by serge-sans-paille

https://github.com/QuantStack/xsimd/commit/63ea057970e1c452334c8adf3d53f7f8a7f59ff2
Authored: 2024-03-19 20:51:20 +0100
Committed: 2024-03-20 17:36:58 +0000

When testing for architecture flag, make sure those flags are not ignored

Fix #999

Files Modified:

• test/architectures/CMakeLists.txt

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=d9fd7045e48e7bc0f729e8320e1090a6b5b7fc27

Comment 2

[Update Bot]

Attachment: Bug 1891462 - Update xsimd to 7eb009bca73e5cc51d05dcfcda25dfb74d6e0aaa

Comment 3

[Update Bot]

It looks like we experienced one or more build failures when trying to apply this
update. You will need to apply this update manually; you can replicate the patch
locally with ./mach vendor third_party/xsimd/moz.yaml. I'm going to abandon the Phabricator patch and
let you submit a new one.

If the build failure wasn't caused by a library change, and was instead caused by
something structural in the build system please let my maintainers know in
Slack:#secinf.

I do my best to automatically add new files to the build, but some moz.build files
are complicated and you may need to fix them manually.

Comment 4

[[:sergesanspaille]]

Attachment: Bug 1891462 - Upgrade xsimd to be9dcb5df413a893fb6646fa950eeb4aeac70ffc r=padenot!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91e58d52ad6a
Upgrade xsimd to fa1890e3b5761fd5432aedd7983349f20354b0e8 (2024-04-16T08:45:12Z) r=padenot

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out 2 changesets (Bug 1891462, Bug 1891990) for Android bustage at xsimd/arch/xsimd_scalar.hpp:95
https://hg.mozilla.org/integration/autoland/rev/fbb31befa31b1e03b29d89f557063c1d4c395393

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Push with failures
Failure log

[task 2024-04-18T15:16:01.305Z] 15:16:01    ERROR -  /builds/worker/checkouts/gecko/third_party/xsimd/include/xsimd/arch/xsimd_scalar.hpp:95:18: error: result of comparison of char expression < 0 is always false, since char is interpreted as unsigned [-Werror,-Wtautological-unsigned-char-zero-compare]
[task 2024-04-18T15:16:01.305Z] 15:16:01     INFO -     95 |         return v < 0 ? -v : v;
[task 2024-04-18T15:16:01.305Z] 15:16:01     INFO -        |                ~ ^ ~
[task 2024-04-18T15:16:01.305Z] 15:16:01     INFO -  1 error generated.
[task 2024-04-18T15:16:01.305Z] 15:16:01    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:688: AudioNodeEngineNEON.o] Error 1

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5164f26ec820
Upgrade xsimd to be9dcb5df413a893fb6646fa950eeb4aeac70ffc r=padenot

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5164f26ec820