1891700 - New wpt failures in /css/css-fonts/parsing/font-palette-values-valid.html

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 45720 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

• /css/css-fonts/parsing/font-palette-values-valid.html [wpt.fyi]
  • CSS Fonts Module Level 4: parsing @font-palette-values 33: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1891571 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[David Shin[:dshin]]

Failure is:

assert_equals: expected "0 color-mix(in lch, red, blue)" but got ""

Comment 2

[Tiaan Louw [:tlouw]]

color-mix(..) was added to the tests as an palette override color and that isn't supported on our side.

https://searchfox.org/mozilla-central/source/servo/components/style/stylesheets/font_palette_values_rule.rs#181

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1891700 - Accept color-mix() in font palette override colors, provided the components used are absolute colors. r=#style

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1891700 - Additional font-palette-values color-mix testcases. r=#style

Add a couple of check for nested color-mix() usage.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c701ad144ae
Accept color-mix() in font palette override colors, provided the components used are absolute colors. r=tlouw
https://hg.mozilla.org/integration/autoland/rev/ca6bbe8eb579
Additional font-palette-values color-mix testcases. r=firefox-style-system-reviewers,emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46282 for changes under testing/web-platform/tests

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9c701ad144ae
https://hg.mozilla.org/mozilla-central/rev/ca6bbe8eb579

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot