1891705 - showNotification resolves too early

Status: RESOLVED DUPLICATE of bug 1928702

(Core :: DOM: Notifications, defect, P3)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

The spec says resolve the promise after fetch and show steps: https://notifications.spec.whatwg.org/#dom-serviceworkerregistration-shownotification

6. Run these steps in parallel:
   1. If the result of getting the notifications permission state is not "granted", then queue a global task on the DOM manipulation task source given global to reject promise with a TypeError, and abort these steps.
   2. Run the fetch steps for notification.
   3. Run the show steps for notification.
   4. Queue a global task on the DOM manipulation task source given global to resolve promise with undefined.
7. Return promise.

But we currently resolve the promise immediately inside the function. https://searchfox.org/mozilla-central/rev/77f8c66362e5f18f8e7cbaf1ba3ed6286f203d33/dom/notification/Notification.cpp#2224

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1891705 - Resolve Promise on alertshow/finished r=asuth

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Bug 1928702 fixed this.