1891740 - Remove `skip-if = condprof` added from test_ext_manifest_incognito.js

Status: RESOLVED FIXED

(WebExtensions :: General, task, P3)

Description

[Rob Wu [:robwu]]

In bug 1876924 I modified the schema definition of incognito and the test at toolkit/components/extensions/test/xpcshell/test_ext_manifest_incognito.js. This test file is listed in xpcshell.toml, which is run as part of the condprof job.

As explained at https://bugzilla.mozilla.org/show_bug.cgi?id=1769184#c3, condprof uses a cached schemas, which would result in CI failures when the schema changes. To avoid schema failures, I'm landing the patch first with skip-if = ["condprof"] and will remove the skip-if after 1-2 days, here.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1891740 - Re-enable test_ext_manifest_incognito.js in condprof

Comment 2

[Rob Wu [:robwu]]

By the way, here is a try push and the relevant error message: https://treeherder.mozilla.org/jobs?repo=try&revision=f4471335ccecc1b6e10c18a1271cc0e84fcb8b26&selectedTaskRun=NFFp-8MWQ2ipvkhXQNayqw.0

INFO - (xpcshell/head.js) | test test_manifest_incognito_split_fallback_not_allowed pending (2)
INFO - "Getting initial pref value for "extensions.incognito.split-as-spanning""
INFO - "Setting pref "extensions.incognito.split-as-spanning": false"
INFO - (xpcshell/head.js) | test run_next_test 3 finished (2)
WARNING - TEST-UNEXPECTED-FAIL | xpcshell.toml:toolkit/components/extensions/test/xpcshell/test_ext_manifest_incognito.js | test_manifest_incognito_split_fallback_not_allowed - [test_manifest_incognito_split_fallback_not_allowed : 74] Should not have an error - "Error processing incognito: Invalid enumeration value \"split\"" == "undefined"

This error is happening because the schema for the manifest is cached, and when condprof is used, the old schema definition is used instead of the one from the patch to bug 1876924. In the new schema, "split" is an acceptable value, but in the old schema it was not. Hence the difference in expectation and the error message above.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c136ba6648ff
Re-enable test_ext_manifest_incognito.js in condprof r=rpl

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c136ba6648ff