1891794 - Intermittent TV chrome://mochitests/content/chrome/dom/base/test/test_anchor_target_blank_referrer.html | changed preference: places.frecency.accelerateRecalculation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nfay [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=454720918&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/FoNn8e1nSiOaE8fBwLrAhA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/FoNn8e1nSiOaE8fBwLrAhA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2024-04-16T16:33:06.636Z] 16:33:06     INFO - TEST-START | dom/base/test/test_anchor_target_blank_referrer.html
[task 2024-04-16T16:33:17.576Z] 16:33:17     INFO - GECKO(2226) | MEMORY STAT | vsize 3314MB | residentFast 461MB | heapAllocated 205MB
[task 2024-04-16T16:33:17.758Z] 16:33:17     INFO - TEST-OK | dom/base/test/test_anchor_target_blank_referrer.html | took 11121ms
[task 2024-04-16T16:33:17.826Z] 16:33:17    ERROR - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/base/test/test_anchor_target_blank_referrer.html | changed preference: places.frecency.accelerateRecalculation
[task 2024-04-16T16:33:17.828Z] 16:33:17     INFO - TEST-START | Shutdown
[task 2024-04-16T16:33:17.828Z] 16:33:17     INFO - Passed:  308
[task 2024-04-16T16:33:17.828Z] 16:33:17     INFO - Failed:  0
[task 2024-04-16T16:33:17.829Z] 16:33:17     INFO - Todo:    0
[task 2024-04-16T16:33:17.829Z] 16:33:17     INFO - Mode:    non-e10s
[task 2024-04-16T16:33:17.830Z] 16:33:17     INFO - Slowest: 12242ms - chrome://mochitests/content/chrome/dom/base/test/test_anchor_target_blank_referrer.html
[task 2024-04-16T16:33:17.830Z] 16:33:17     INFO - TEST-INFO | Ran 11 Loops
[task 2024-04-16T16:33:17.830Z] 16:33:17     INFO - SimpleTest FINISHED
[task 2024-04-16T16:33:17.869Z] 16:33:17     INFO - TEST-INFO | Main app process: exit 0
[task 2024-04-16T16:33:17.869Z] 16:33:17     INFO - runtests.py | Application ran for: 0:02:14.500236
[task 2024-04-16T16:33:17.870Z] 16:33:17     INFO - zombiecheck | Reading PID log: /tmp/tmpv0c728zwpidlog
[task 2024-04-16T16:33:17.870Z] 16:33:17     INFO - ==> process 2226 launched child process 2313
[task 2024-04-16T16:33:17.870Z] 16:33:17     INFO - zombiecheck | Checking for orphan process with PID: 2313
[task 2024-04-16T16:33:17.870Z] 16:33:17     INFO - Stopping web server
[task 2024-04-16T16:33:17.873Z] 16:33:17     INFO - Server shut down.
[task 2024-04-16T16:33:17.879Z] 16:33:17     INFO - Web server killed.
[task 2024-04-16T16:33:17.879Z] 16:33:17     INFO - Stopping web socket server
[task 2024-04-16T16:33:17.879Z] 16:33:17     INFO - Stopping ssltunnel
[task 2024-04-16T16:33:17.881Z] 16:33:17     INFO - Stopping gst for v4l2loopback
[task 2024-04-16T16:33:17.882Z] 16:33:17  WARNING - leakcheck | refcount logging is off, so leaks can't be detected!
[task 2024-04-16T16:33:17.882Z] 16:33:17     INFO - runtests.py | Running tests: end.
[task 2024-04-16T16:33:18.033Z] 16:33:18     INFO - Buffered messages finished
[task 2024-04-16T16:33:18.034Z] 16:33:18     INFO -  0 INFO TEST-START | Shutdown
[task 2024-04-16T16:33:18.035Z] 16:33:18     INFO -  1 INFO Passed:  3836
[task 2024-04-16T16:33:18.035Z] 16:33:18     INFO -  2 INFO Failed:  0
[task 2024-04-16T16:33:18.035Z] 16:33:18     INFO -  3 INFO Todo:    0
[task 2024-04-16T16:33:18.036Z] 16:33:18     INFO -  4 INFO Mode:    non-e10s
[task 2024-04-16T16:33:18.036Z] 16:33:18     INFO -  5 INFO SimpleTest FINISHED
[task 2024-04-16T16:33:18.036Z] 16:33:18     INFO - Buffered messages finished
[task 2024-04-16T16:33:18.037Z] 16:33:18     INFO - SUITE-END | took 135s

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:ckerschb, since you are the author of the regressor, bug 1891694, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1891694

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #1)

:ckerschb, since you are the author of the regressor, bug 1891694, could you take a look?

I doubt that my change is responsible here. https-first is not enabled at the moment and the only update I made within this test is to explicitly set the pref to false so in case we do enable https-first by default the test still passes.

Comment 4

[Intermittent Failures Robot]

4 failures in 4252 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4

Platform and build breakdown:

• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• macosx1015-64-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1891794&startday=2024-04-15&endday=2024-04-21&tree=all

Comment 5

[Manuel Bucher [:manuel]]

This pref was introduced in Bug 1873629. I do have new tests that also see this intermittent failure: https://treeherder.mozilla.org/jobs?repo=try&revision=bf9b1a69d4fe0a95fcdd9486cd2c853ead21b656&selectedTaskRun=WTJnBAZNTs-zZvoZKMbhWQ.0

@mak: How best to fix the intermittent behavior? Is there a pref that should be disabled for all tests? Do we need to clear the pref at the end of the test case? Or mark it as an exception somehow to not make it fail the test run?

Comment 6

[Marco Bonardo [:mak]]

It looks like this failure has been introduced in bug 1783248, the pref should be added to testing/mochitest/ignorePrefs.json, as it's unlikely to influence these...
I'm not 100% sure the approach of bug 1783248 is sustainable long term as prefs can really change at any time, it may create this kind of noise and the allowlist will keep growing until the protection loses some of the original benefits.

Comment 7

[Manuel Bucher [:manuel]]

Attachment: Bug 1891794 - Ignore changes in places.frecency.accelerateRecalculation in verify mochitests r=mak

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/535080177d46
Ignore changes in places.frecency.accelerateRecalculation in verify mochitests r=mak

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/535080177d46

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:manuel, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.