Closed Bug 1891840 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 45747 - Deflake attempt for fenced frame null config -> about:blank WPT

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45747 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45747
Details from upstream follow.

Andrew Verge <averge@chromium.org> wrote:

Deflake attempt for fenced frame null config -> about:blank WPT

There are a few things wrong with this test (I was relatively new
to WPTs when I wrote it):

  1. attachFencedFrameContext had no await, meaning that there
    is no guarantee that the frame context exists before operating on it.
    I'm assuming this is the reason for most of the failures, and have
    fixed it.
  2. The test had a probably-unnecessarily-long timeout, which I cut in
    half to 1.5s
  3. There was no meta timeout tag, which I've added just in case the
    1.5s timeout causes breakage on slower builders.

I know that timeouts in tests are not ideal, but this test relies on
one because all other code that could be used to observe the fenced
frame is removed when navigating to about:blank.

Bug: 333501264
Change-Id: Ia54c69bde836f0b6bcb06a4cb1863d9de1d1c5e7
Reviewed-on: https://chromium-review.googlesource.com/5459098
WPT-Export-Revision: 0c7266f7cf642cbc6e6e6119e7efd5e43bbe7b4e

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fenced-frame/setting-null-config-navigates-to-about-blank.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • Test that a fenced frame with a config explicitly set to null navigates to about:blank: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /fenced-frame/setting-null-config-navigates-to-about-blank.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb16fcce8c12 [wpt PR 45747] - Deflake attempt for fenced frame null config -> about:blank WPT, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.