Closed Bug 1891940 Opened 7 months ago Closed 7 months ago

[wpt-sync] Sync PR 45759 - Tests for an explicit `initial` and “space” style queries

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45759 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45759
Details from upstream follow.

Roman Komarov <kizmarh@ya.ru> wrote:

Tests for an explicit initial and “space” style queries

I was playing with style queries and using “space toggles” to apply them (article 1, article 2), and discovered an issue with an explicit initial value in Safari Technology Preview.

I did open a bug: https://bugs.webkit.org/show_bug.cgi?id=270739, and now I am submitting the tests that cover this case, as well as additional tests for the “space” value (which pass in Chrome and WebKit, making testing for the space a good workaround for this for now), just in case, so it would be explicitly covered.

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 77 subtests

Status Summary

Firefox

OK : 1
PASS: 26
FAIL: 51

Chrome

OK : 1
PASS: 77

Safari

OK : 1
PASS: 75
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-contain/container-queries/custom-property-style-queries.html [wpt.fyi]
    • style(--inner: true): FAIL linked bug:Bug 1802763
    • style(--inner:true): FAIL linked bug:Bug 1802763
    • style(--inner:true ): FAIL linked bug:Bug 1802763
    • style(--inner: true ): FAIL linked bug:Bug 1802763
    • style(--inner-no-space: true): FAIL linked bug:Bug 1802763
    • style(--inner-no-space:true): FAIL linked bug:Bug 1802763
    • style(--inner-no-space:true ): FAIL linked bug:Bug 1802763
    • style(--inner-no-space: true ): FAIL linked bug:Bug 1802763
    • style(--inner-space-after: true): FAIL linked bug:Bug 1802763
    • style(--inner-space-after:true): FAIL linked bug:Bug 1802763
    • style(--inner-space-after:true ): FAIL linked bug:Bug 1802763
    • style(--inner-space-after: true ): FAIL linked bug:Bug 1802763
    • outer style(--outer: true): FAIL linked bug:Bug 1802763
    • outer style(--outer:true): FAIL linked bug:Bug 1802763
    • outer style(--outer:true ): FAIL linked bug:Bug 1802763
    • outer style(--outer: true ): FAIL linked bug:Bug 1802763
    • outer style(--outer-no-space: true): FAIL linked bug:Bug 1802763
    • outer style(--outer-no-space:true): FAIL linked bug:Bug 1802763
    • outer style(--outer-no-space:true ): FAIL linked bug:Bug 1802763
    • outer style(--outer-no-space: true ): FAIL linked bug:Bug 1802763
    • outer style(--outer-space-after: true): FAIL linked bug:Bug 1802763
    • outer style(--outer-space-after:true): FAIL linked bug:Bug 1802763
    • outer style(--outer-space-after:true ): FAIL linked bug:Bug 1802763
    • outer style(--outer-space-after: true ): FAIL linked bug:Bug 1802763
    • Query custom property with !important declaration: FAIL linked bug:Bug 1802763
    • Query custom property using var(): FAIL linked bug:Bug 1802763
    • Query custom property including unknown var() reference: FAIL linked bug:Bug 1802763
    • Query custom property including unknown var() reference with non-matching fallback: FAIL linked bug:Bug 1802763
    • Query custom property including unknown var() reference with matching fallback: FAIL linked bug:Bug 1802763
    • Query custom property matching guaranteed-invalid values: FAIL linked bug:Bug 1802763
    • Style query 'initial' matching: FAIL linked bug:Bug 1802763
    • Style query matching negated value-less query against initial value: FAIL linked bug:Bug 1881854
    • Style query 'initial' not matching: FAIL linked bug:Bug 1802763
    • Style query matching value-less query against non-initial value: FAIL linked bug:Bug 1881854
    • Style query 'space' matching: FAIL
    • Style query 'space' not matching: FAIL
    • Style query 'inherit' matching: FAIL linked bug:Bug 1802763
    • Style query 'inherit' not matching: FAIL linked bug:Bug 1802763
    • Style query 'unset' matching: FAIL linked bug:Bug 1802763
    • Style query 'unset' not matching: FAIL linked bug:Bug 1802763
    • Match registered <length> custom property with px.: FAIL linked bug:Bug 1802763
    • Match registered <length> custom property with px via initial keyword.: FAIL linked bug:Bug 1881854
    • Match registered <length> custom property with em in query.: FAIL linked bug:Bug 1802763
    • Match registered <length> custom property with em in computed value.: FAIL linked bug:Bug 1802763
    • Match registered <length> custom property with cqi unit.: FAIL linked bug:Bug 1802763
    • Match registered <length> custom property with initial value.: FAIL linked bug:Bug 1881854
    • Match registered <length> custom property with initial value via initial keyword.: FAIL linked bug:Bug 1881854
    • Should only match exact string for numbers in non-registered custom properties: FAIL linked bug:Bug 1881854
    • Spaces should not collapse in non-registered custom properties: FAIL linked bug:Bug 1881854

New Tests That Don't Pass

  • /css/css-contain/container-queries/custom-property-style-queries.html [wpt.fyi]
    • style(--inner: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner: true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-no-space: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-no-space:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-no-space:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-no-space: true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-space-after: true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-space-after:true): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-space-after:true ): FAIL (Chrome: PASS, Safari: PASS)
    • style(--inner-space-after: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-no-space: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-no-space:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-no-space:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-no-space: true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-space-after: true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-space-after:true): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-space-after:true ): FAIL (Chrome: PASS, Safari: PASS)
    • outer style(--outer-space-after: true ): FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property with !important declaration: FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property using var(): FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property including unknown var() reference: FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property including unknown var() reference with non-matching fallback: FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property including unknown var() reference with matching fallback: FAIL (Chrome: PASS, Safari: PASS)
    • Query custom property matching guaranteed-invalid values: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'initial' matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query matching negated value-less query against initial value: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'initial' not matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query matching value-less query against non-initial value: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'initial' matching (with explicit 'initial' value): FAIL (Chrome: PASS, Safari: FAIL)
    • Style query matching negated value-less query against initial value (with explicit 'initial' value): FAIL (Chrome: PASS, Safari: FAIL)
    • Style query 'space' matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'space' not matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'inherit' matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'inherit' not matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'unset' matching: FAIL (Chrome: PASS, Safari: PASS)
    • Style query 'unset' not matching: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with px.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with px via initial keyword.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with em in query.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with em in computed value.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with cqi unit.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with initial value.: FAIL (Chrome: PASS, Safari: PASS)
    • Match registered <length> custom property with initial value via initial keyword.: FAIL (Chrome: PASS, Safari: PASS)
    • Should only match exact string for numbers in non-registered custom properties: FAIL (Chrome: PASS, Safari: PASS)
    • Spaces should not collapse in non-registered custom properties: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1fd94c960aa9 [wpt PR 45759] - Tests for an explicit `initial` and “space” style queries, a=testonly https://hg.mozilla.org/integration/autoland/rev/0b8ca88ae3d6 [wpt PR 45759] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1fd94c960aa9
https://hg.mozilla.org/mozilla-central/rev/0b8ca88ae3d6

Status: NEW → RESOLVED
Closed: 7 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.