Closed
Bug 1891985
Opened 1 year ago
Closed 11 months ago
Remove extraneous code from TopSites
Categories
(Firefox :: Top Sites, task, P1)
Firefox
Top Sites
Tracking
()
RESOLVED
FIXED
128 Branch
Tracking | Status | |
---|---|---|
firefox128 | --- | fixed |
People
(Reporter: jteow, Assigned: jteow)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sng])
Attachments
(4 files)
Some of the copied code from TopSitesFeed is heavily tied to New Tab specific logic or is deprecated.
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Telementry is dependent on the use of Contile which will be removed
from the TopSites component.
Assignee | ||
Comment 2•1 year ago
|
||
Depends on D209442
Assignee | ||
Comment 3•1 year ago
|
||
From talking with the New Tab team, there are no plans to get sponsored
tiles from the Remote Settings collection.
Depends on D209443
Assignee | ||
Comment 4•1 year ago
|
||
As far as I know using the UI, there's no way to expand/collapse the
Top Sites row anymore.
Depends on D209444
Updated•1 year ago
|
Assignee: nobody → jteow
Attachment #9400076 -
Attachment description: WIP: - Bug 1891985 - Part 1: Remove TopSitesTelemetry - r?dao! → Bug 1891985 - Part 1: Remove TopSitesTelemetry - r?dao!
Status: NEW → ASSIGNED
Updated•1 year ago
|
Attachment #9400077 -
Attachment description: WIP: Bug 1891985 - Part 2: Remove Contile/SPOC/Moz Sales/Discovery Stream from TopSites component - r?dao! → Bug 1891985 - Part 2: Remove Contile/SPOC/Moz Sales/Discovery Stream from TopSites component - r?dao!
Updated•1 year ago
|
Attachment #9400078 -
Attachment description: WIP: - Bug 1891985 - Part 3: Remove ability to show sponsored tiles from Remote Settings - r?dao! → Bug 1891985 - Part 3: Remove ability to show sponsored tiles from Remote Settings - r?dao!
Updated•1 year ago
|
Attachment #9400079 -
Attachment description: WIP: - Bug 1891985 - Part 4: Remove Section pref listener - r?dao! → Bug 1891985 - Part 4: Remove Section pref listener - r?dao!
Pushed by jteow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/490d73e654f2
Part 1: Remove TopSitesTelemetry - r=dao
https://hg.mozilla.org/integration/autoland/rev/6b308cde050d
Part 2: Remove Contile/SPOC/Moz Sales/Discovery Stream from TopSites component - r=dao
https://hg.mozilla.org/integration/autoland/rev/a6724d6dafbf
Part 3: Remove ability to show sponsored tiles from Remote Settings - r=dao
https://hg.mozilla.org/integration/autoland/rev/efc1a6318749
Part 4: Remove Section pref listener - r=dao
Comment 6•11 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/490d73e654f2
https://hg.mozilla.org/mozilla-central/rev/6b308cde050d
https://hg.mozilla.org/mozilla-central/rev/a6724d6dafbf
https://hg.mozilla.org/mozilla-central/rev/efc1a6318749
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•