1892019 - [toolbar redesign] Refactor toolbar into a new component toolbar2 that only new toolbar can use

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P1)

Description

[[:skhan]]

With the recent information of the toolbar redesign just being utilized by fenix and not focus (or other consumers of AC) , we decided to investigate on creating a similar toolbar2 component in AC that has everything related to toolbar redesign and can just be used by fenix.

Comment 1

[Roger Yang [:royang]]

Attachment: Bug 1892019 - Create Toolbar2 from Toolbar

Comment 2

[Roger Yang [:royang]]

Attachment: Bug 1892019 - Create Toolbar2 from Toolbar

Comment 3

[Roger Yang [:royang]]

Attachment: Bug 1892019 - Update Toolbar2 naming to match component name

Depends on D208037

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d84d17193a35
Create Toolbar2 from Toolbar r=android-reviewers,gl
https://hg.mozilla.org/integration/autoland/rev/7fcfe37a87ef
Update Toolbar2 naming to match component name r=android-reviewers,gl

Comment 5

[Iulian Moraru]

Backed out for causing gecko decision task bustages.

• Push with failures

• Failure log

• Backout link

[task 2024-04-22T22:22:58.087Z] Generating tasks for build-components release-ui-widgets
[task 2024-04-22T22:22:58.123Z] Error loading tasks for kind build-components:
[task 2024-04-22T22:22:58.123Z] Traceback (most recent call last):
[task 2024-04-22T22:22:58.123Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 311, in _run
[task 2024-04-22T22:22:58.123Z]     new_tasks = kind.load_tasks(
[task 2024-04-22T22:22:58.123Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 76, in load_tasks
[task 2024-04-22T22:22:58.123Z]     tasks = [
[task 2024-04-22T22:22:58.123Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 76, in <listcomp>
[task 2024-04-22T22:22:58.123Z]     tasks = [
[task 2024-04-22T22:22:58.123Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 2271, in check_run_task_caches
[task 2024-04-22T22:22:58.123Z]     for task in tasks:
[task 2024-04-22T22:22:58.123Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 2181, in check_task_dependencies
[task 2024-04-22T22:22:58.123Z]     for task in tasks:
[task 2024-04-22T22:22:58.123Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 2167, in check_task_identifiers
[task 2024-04-22T22:22:58.123Z]     for task in tasks:
[task 2024-04-22T22:22:58.123Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 2148, in chain_of_trust
[task 2024-04-22T22:22:58.123Z]     for task in tasks:
[task 2024-04-22T22:22:58.123Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 1991, in build_task
[task 2024-04-22T22:22:58.123Z]     raise Exception(UNKNOWN_GROUP_NAME.format(groupSymbol, path))
[task 2024-04-22T22:22:58.123Z] Exception: Treeherder group browser-toolbar2 (from taskcluster/kinds/build-components/kind.yml) has no name; add it to taskcluster/config.yml
[task 2024-04-22T22:22:58.124Z] Traceback (most recent call last):
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 209, in taskgraph_decision
[task 2024-04-22T22:22:58.124Z]     ret = taskgraph_commands["decision"].func(options)
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/main.py", line 703, in decision
[task 2024-04-22T22:22:58.124Z]     taskgraph_decision(options)
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/decision.py", line 199, in taskgraph_decision
[task 2024-04-22T22:22:58.124Z]     full_task_json = tgg.full_task_graph.to_json()
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 170, in full_task_graph
[task 2024-04-22T22:22:58.124Z]     return self._run_until("full_task_graph")
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 425, in _run_until
[task 2024-04-22T22:22:58.124Z]     k, v = next(self._run)
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 311, in _run
[task 2024-04-22T22:22:58.124Z]     new_tasks = kind.load_tasks(
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 76, in load_tasks
[task 2024-04-22T22:22:58.124Z]     tasks = [
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 76, in <listcomp>
[task 2024-04-22T22:22:58.124Z]     tasks = [
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 2271, in check_run_task_caches
[task 2024-04-22T22:22:58.124Z]     for task in tasks:
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 2181, in check_task_dependencies
[task 2024-04-22T22:22:58.124Z]     for task in tasks:
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 2167, in check_task_identifiers
[task 2024-04-22T22:22:58.124Z]     for task in tasks:
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 2148, in chain_of_trust
[task 2024-04-22T22:22:58.124Z]     for task in tasks:
[task 2024-04-22T22:22:58.124Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/transforms/task.py", line 1991, in build_task
[task 2024-04-22T22:22:58.124Z]     raise Exception(UNKNOWN_GROUP_NAME.format(groupSymbol, path))
[task 2024-04-22T22:22:58.124Z] Exception: Treeherder group browser-toolbar2 (from taskcluster/kinds/build-components/kind.yml) has no name; add it to taskcluster/config.yml
[task 2024-04-22T22:22:58.124Z] Creating default state directory: /builds/worker/.mozbuild
[task 2024-04-22T22:22:58.124Z] Creating local state directory: /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69
[taskcluster 2024-04-22 22:22:58.551Z] === Task Finished ===
[taskcluster 2024-04-22 22:23:09.974Z] Unsuccessful task run with exit code: 1 completed in 52.36 seconds

Comment 6

[Roger Yang [:royang]]

Attachment: Bug 1892019 - Add browser-toolbar2 to taskcluster config

Depends on D208038

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b5e273a4359
Create Toolbar2 from Toolbar r=android-reviewers,gl
https://hg.mozilla.org/integration/autoland/rev/a00027bdee11
Update Toolbar2 naming to match component name r=android-reviewers,gl
https://hg.mozilla.org/integration/autoland/rev/b65d6501e3d2
Add browser-toolbar2 to taskcluster config r=aryx

Comment 8

[Roger Yang [:royang]]

Attachment: Bug 1892019 - Exclude Toolbar2 resource files from licence lint

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9787c91fdca
Exclude Toolbar2 resource files from licence lint. r=lint-fix CLOSED TREE

Comment 10

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/4b5e273a4359
https://hg.mozilla.org/mozilla-central/rev/a00027bdee11
https://hg.mozilla.org/mozilla-central/rev/b65d6501e3d2
https://hg.mozilla.org/mozilla-central/rev/a9787c91fdca

Comment 11

[Roger Yang [:royang]]

Attachment: Bug 1892019 - Move toolbar2 to toolbar-legacy

Comment 12

[Roger Yang [:royang]]

Attachment: Bug 1892019 - Fix description for toolbar clear URL text button string

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3de3f9428f13
Fix description for toolbar clear URL text button string r=android-reviewers,skhan

Comment 14

[Aron Cseh [:acseh]]

https://hg.mozilla.org/mozilla-central/rev/3de3f9428f13

Comment 15

[[:skhan]]

Attachment: Bug 1892019 - Add and utilize InteractionToolbar interface

Comment 16

[[:skhan]]

Attachment: Bug 1892019 - Utilize InteractionToolbar in Fenix

Comment 17

[[:skhan]]

Attachment: Bug 1892019 - Utilize InteractionToolbar in focus

Comment 18

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Nightly blockers to priority P1.

Comment 19

[Roger Yang [:royang]]

Closing this issue since all needed patches have landed and the the follow up patches will be abandoned.