1892074 - restoreThreadState() is not called when changing sort order for virtual folders

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect, P1)

Description

[Alessandro Castellani [:aleca]]

STR:

• Open a virtual folder (example tags)
• Set cards view
• Change the sort order to Grouped by sort, and back to Threaded

The style is not properly updated because the restoreThreadState() method is never called, so the proper attributes are never refreshed.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

This is because the view isn't regenerated or resorted in this case, see here. I think threadTree.dataset.showGroupedBySort should be set in this function here. Maybe we could extract this setting from restoreThreadState() and make it its own function to be more flexible.

Comment 2

[Alessandro Castellani [:aleca]]

I'm also noticing that for regular folder the command is run twice...oh boy

console.trace:
chrome://messenger/content/about3Pane.js 4790 restoreThreadState
chrome://messenger/content/mailCommon.js 993 onCreatedView
resource:///modules/DBViewWrapper.sys.mjs 1544 _applyViewChanges
resource:///modules/DBViewWrapper.sys.mjs 1509 set _viewFlags
resource:///modules/DBViewWrapper.sys.mjs 1948 set showThreaded
chrome://messenger/content/about3Pane.js 6220 sortThreaded
chrome://messenger/content/about3Pane.js 6078 handleCommand
chrome://messenger/content/about3Pane.js 6260
chrome://messenger/content/mailCommon.js 733 doCommand
chrome://messenger/content/globalOverlay.js 99 goDoCommand
about:3pane 1 oncommand
console.trace:
chrome://messenger/content/about3Pane.js 4790 restoreThreadState
chrome://messenger/content/mailCommon.js 1026 onMessagesLoaded
resource:///modules/DBViewWrapper.sys.mjs 1558 _applyViewChanges
resource:///modules/DBViewWrapper.sys.mjs 1509 set _viewFlags
resource:///modules/DBViewWrapper.sys.mjs 1948 set showThreaded
chrome://messenger/content/about3Pane.js 6220 sortThreaded
chrome://messenger/content/about3Pane.js 6078 handleCommand
chrome://messenger/content/about3Pane.js 6260
chrome://messenger/content/mailCommon.js 733 doCommand
chrome://messenger/content/globalOverlay.js 99 goDoCommand
about:3pane 1 oncommand

Comment 3

[Hartmut Welpmann [:welpy-cw]]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #1)

I think threadTree.dataset.showGroupedBySort should be set in this function here. Maybe we could extract this setting from restoreThreadState() and make it its own function to be more flexible.

Or just put it into updateListRole().

Comment 4

[Alessandro Castellani [:aleca]]

We need a condition that distinguish regular folders from smart folders (does it only affect smart tags folders?) and run the restoreThreadState() only for those because all other scenarios are covered by the set _viewFlags() as you correctly pointed out.

Or maybe we should take a hard a look at the DBViewWrapper.sys.mjs and properly fix this inconsistency, if possible.

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1892074 - Make restoreThreadState() more versatile. r=#thunderbird-reviewers

• Set proper style attributes in threadTree when changing between grouped-by-sort and threaded in multi-folder search views.
• Actually set the collapsed/expanded state either in onCreatedView or in onMessagesLoaded(all)
• Correctly restore expand-all state of grouped-by-sort multi-folder search views (Bug 1892065)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/76db2279c298
Make restoreThreadState() more versatile. r=aleca

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9397256 [details]
Bug 1892074 - Make restoreThreadState() more versatile. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1889021
User impact if declined: expand-all state of grouped-by-sort multi-folder search views is not restored.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9397256 [details]
Bug 1892074 - Make restoreThreadState() more versatile. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 126.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/eefb30e3d2ce

Comment 10

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Managed to reproduce the issue with the affected build from 2024-04-17 (20240417092556) .

Confirming this issue as verified fixed with 126.0b3(20240506165103) using Windows 11, macOS 14 and Ubuntu 22.