Closed Bug 1892121 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 45773 - Make cross-origin-ancestor-activeelement-after-child-lose-focus.sub.html more robust.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox127 fixed)

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45773 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45773
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Make cross-origin-ancestor-activeelement-after-child-lose-focus.sub.html more robust.

This makes two changes to try to make the test
cross-origin-ancestor-activeelement-after-child-lose-focus.sub.html more
robust:

  • It checks the message data in case postMessage is used by something
    else in WPT (although I think this is unlikely), to make sure that the
    message received is the one intended (that is sent by the subframe's
    subframe).
  • It makes the subframe's subframe wait until load before focusing its
    input, on the theory that it might be possible that this focusing is
    happening too early to be effective.

My hope is that these might fix the test being flaky in Chromium CI.

Bug: 332068449
Change-Id: Idf70ba87a8559223f9dff7900cadca9ea56126e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464001
Auto-Submit: David Baron \<dbaron@chromium.org>
Commit-Queue: Di Zhang \<dizhangg@chromium.org>
Reviewed-by: Di Zhang \<dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1288995}

PR 45773 applied with additional changes from upstream: 98177f30f833ad09ed70d5ab00560d7a92a23a93

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS : 1

Chrome

OK : 1
PASS : 1

Safari

PASS : 1
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1762af567ee3 [wpt PR 45773] - Make cross-origin-ancestor-activeelement-after-child-lose-focus.sub.html more robust., a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.