1892189 - Add DO_NOT_COMMIT_HERE with explanations to nspr/nss snapshot directories

Status: RESOLVED INVALID

(Firefox Build System :: General, enhancement)

Description

[Kai Engert (:KaiE:)]

Let's try to make it easier to notice that no individual commits should be added in the security/nss and nsprpub directories.

Comment 1

[Mike Hommey [:glandium]]

I doubt such files would be noticed. It seems to me you should set up herald rules to add mandatory reviewers for patches touching these directories.

Comment 2

[Mike Hommey [:glandium]]

I doubt such files would be noticed.

Heck, people still modify files that have a header that explicitly says not to edit them. In huge letters. So, really, I wouldn't expect they'd find out about a separate file from the one they are editing.

Comment 3

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Glandium and I think this isn't worthwhile. It's also not exactly related to the build system.

I'm gonna close this, but if you really want to pursue this you can re-raise it under a different product.