1892244 - 19.88% damp custom.jsdebugger.preview.DAMP (Windows) regression on Thu April 4 2024

Status: NEW

(DevTools :: Debugger, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance regression from push 2bb244f58cca756086de06c710e990072f5add53. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
20%	damp custom.jsdebugger.preview.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	578.98 -> 694.11

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42175

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 2

[Dianna Smith [:diannaS]]

Looks like the only bug in that push is bug 1887719. :emilio could you take a look?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

It seems it was mostly an improvement given https://treeherder.mozilla.org/perfherder/alerts?id=42171&hideDwnToInv=0?

So I can probably debug this a bit more, but I'm a bit swamped so maybe worth closing as-is?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

The push from the alert might not be the one that introduced this. We filed the bug mostly to at least find out if that's the case.
The regression is windows only, which is not very common for devtools tests , so it'd be nice to see what's happening (it might just be that the test is impacted by timing shifts that are happening in tests before this one)

Comment 5

[Pascal Chevrel:pascalc]

Could we get a priority set please? Thanks