1892292 - HANG when running ./mach vendor media/libyuv/moz.yaml --patch-mode only

Status: RESOLVED FIXED

(Developer Infrastructure :: Mach Vendor & Updatebot, defect)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

A hang occurs when running ./mach vendor media/libyuv/moz.yaml --patch-mode only. A ^C^C yields a python trace indicating that the hang is occurring during the patch command execution. The user is prompted for input when I run that command locally:

$ patch -p1 --directory media/libyuv/libyuv/ --input $HOME/dev/mozilla-unified/media/libyuv/fix_build_errors. patch --no-backup-if-mismatch
patching file 'include/libyuv/row.h'
Reversed (or previously applied) patch detected!  Assume -R? [y]

patch --version yields patch 2.0-12u11-Apple

This triggered by user error. I ran mach vendor with --patch-mode=only before running it with --patch-mode=none. In that case, the prompt that patch presented was exactly what it should have done. mach vendor could point one in the right direction if patch prompts in this way.

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1892292: Have a better error message for when patching fails r?maltejur

Comment 2

[Tom Ritter [:tjr]]

I've attached a patch the better improve the error message; but I can't replicate the hang behavior - it might be specific to the mac version of patch?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84c3ffaba300
Have a better error message for when patching fails r=maltejur

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/84c3ffaba300