1892376 - Make `EditorBase::CloneAttributesWithTransaction()` not use `nsDOMAttributeMap`

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://phabricator.services.mozilla.com/D207241#inline-1149106

I'll note that using nsDOMAttributeMap for code like this is not great, it's really only meant to be used from JS. It creates attribute nodes for all attributes, which you don't really need here. It would be better to use Element::GetAttrCount/GetAttrInfoAt, which allows you to get the nodeinfo and value for all attributes for an element.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1892376 - Make `EditorBase` and `HTMLEditor` not use `nsDOMAttributeMap` r=peterv!,#dom-core

nsDOMAttributeMap::GetAttribute creates dom::Attr so that it's not cheap.
Instead it should access Element::mAttrs with the accessors or
BorrowedAttrInfo.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2379d951ae10
Make `EditorBase` and `HTMLEditor` not use `nsDOMAttributeMap` r=peterv,dom-core

Comment 3

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/2379d951ae10