1892430 - Add a "Hide" sidebar visibility setting

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Sarah Clements [:sclements]]

This patch will add a "Hide Sidebar" setting to the Customization Menu and needs to have specific behaviors:

• The sidebar is hidden by default until the user clicks the sidebar toolbar button.
• When clicked, the sidebar shows the expanded state (with icons and titles)
• If a user selects a "tool" (ie, history) or sidebar extension, it opens the corresponding panel.
• If a user closes the panel or clicks on the corresponding icon in the sidebar, it closes the panel and goes back to the expanded sidebar state.
• But the sidebar toolbar button with this setting only hides or shows the sidebar (including the panel if open).

This clickable figma prototype will better illustrate the sequences.

We'll need to persist this setting across windows and sessions.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1892430 - Add a "Hide" sidebar visibility setting r?#sidebar-reviewers!

The toggle was there to begin with, but this commit actually gets it working to spec.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dd1d0d671b0
Add a "Hide" sidebar visibility setting r=sidebar-reviewers,sessionstore-reviewers,sclements

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/0dd1d0d671b0