1892485 - [wpt-sync] Sync PR 45806 - [CSS Highlight Pseudos] Resolve var() using the originating element

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45806 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45806
Details from upstream follow.

Stephen Chenney <[e-mail]> wrote:

[CSS Highlight Pseudos] Resolve var() using the originating element

To support the existing common case, while still enabling
highlight inheritance, this CL enables highlight pseudos
resolving var() using custom properties from the originating element.

The previously recommended way to achieve the highlight inheritance
behavior was via custom property inheritance on the originating elements, with highlights using the custom properties from their originating element. This standard approach fails when highlight inheritance is enabled because the custom properties come from the highlight cascade.

This code allows the previous method to coexist with highlight
inheritance, with the goal of making it possible to launch the
feature without breaking too many sites.

Bug: b/323738272
Change-Id: I0f828584a491bd1c39211f501dd4b31edc22e125
Reviewed-on: https://chromium-review.googlesource.com/5265437
WPT-Export-Revision: d1bfab49b579de14a5807e699b8b2942cb810aa8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cea5dfbea18a7f17c353a3363bc2e7290b7c99e0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 4 subtests

Status Summary

Firefox

OK : 1
PASS: 3
FAIL: 5

Chrome

OK : 1
PASS: 1
FAIL: 7

Safari

OK : 1
PASS: 2
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-pseudo/highlight-custom-properties-dynamic-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-pseudo/highlight-styling-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-pseudo/highlight-cascade-009.html [wpt.fyi]
  • body ::selection does not use its own custom property: FAIL (Chrome: FAIL, Safari: FAIL)
  • div::selection uses the originating element custom property: FAIL (Chrome: FAIL, Safari: FAIL)
  • div::selection does not use its own custom property: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ab3e7a8e50a
[wpt PR 45806] - [CSS Highlight Pseudos] Resolve var() using the originating element, a=testonly
https://hg.mozilla.org/integration/autoland/rev/484834fa87d4
[wpt PR 45806] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7ab3e7a8e50a
https://hg.mozilla.org/mozilla-central/rev/484834fa87d4