1892553 - WPT failures in /webauthn/createcredential-pubkeycredparams.https.html

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, defect, P5)

Description

[Thomas Wisniewski [:twisniewski]]

We're failing four tets in this WPT:

It's just because we're not throwing a TypeError, but rather a SecurityError.

We can pass the tests by just changing this line to something like:

    promise->MaybeRejectWithTypeError("No supported types in pubKeyCredParams");

But I think the test is wrong, and should expect a NotSupportedError as we fail with, as per https://www.w3.org/TR/webauthn-2/#ref-for-list-is-empty%E2%91%A1

What do you think, :jschanck?

Comment 1

[John Schanck [:jschanck]]

Yes, the test is wrong. There's an open pull request to fix it: https://github.com/web-platform-tests/wpt/pull/34471, although there's no activity on it recently. We can try to move that along.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Sure, I've commented on the related crbug to see if they would mind me adjusting the test's expectations early, given that their bug has stalled.

Comment 3

[Thomas Wisniewski [:twisniewski]]

They replied to go for it, so since we pass their proposed WPT changes in https://github.com/web-platform-tests/wpt/pull/34471/files, I think we ought to just land that patch (but that patch requires an modification to add quotes to NotSupportedError error, so I can't just merge it as-is, so I'll add a revised patch here with just that change compared to their proposed commit).

Comment 4

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1892553 - import the test-changes from https://github.com/web-platform-tests/wpt/pull/34471/files to correct the WPTs; r?jschanck

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f55348e18925
import the test-changes from https://github.com/web-platform-tests/wpt/pull/34471/files to correct the WPTs; r=jschanck

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46105 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f55348e18925

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot