1892636 - Update opus to new version dfd4175a90a7c0fbd67799b9e3ad93611027c904 from 2024-04-21 16:45:48

Status: RESOLVED DUPLICATE of bug 1892927

(Core :: Audio/Video: Playback, enhancement)

Description

[Update Bot]

This update covers 2 commits. Here are the overall diff statistics, and then the commit information.

---

media/libopus/moz.build | 2 +-
media/libopus/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

dfd4175a90a7c0fbd67799b9e3ad93611027c904 by Jan Buethe

https://gitlab.xiph.org/xiph/opus/commit/dfd4175a90a7c0fbd67799b9e3ad93611027c904
Authored: 2024-04-21 16:45:48 +0200
Committed: 2024-04-21 16:45:48 +0200

updates in download_model.sh (more verbose now)

Files Modified:

• dnn/download_model.sh

---

9faf6f071cbb75432bfbc7fb7286d49eb2ba8512 by Jan Buethe

https://gitlab.xiph.org/xiph/opus/commit/9faf6f071cbb75432bfbc7fb7286d49eb2ba8512
Authored: 2024-04-20 07:57:52 +0200
Committed: 2024-04-20 07:57:52 +0200

added sha256 check for downloaded data

Files Modified:

• autogen.sh
• dnn/download_model.sh

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=0424c1f73e6adb20cf28e3ee57e2431b1f90e5b1

Comment 2

[Update Bot]

Attachment: Bug 1892636 - Update opus to dfd4175a90a7c0fbd67799b9e3ad93611027c904

Comment 3

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• No tests were found for flavor 'plain' and the following manifest filters:
  skip_if, run_if, fail_if, subsuite(name=media), tags(['media-engine-compatible']), pathprefix(['dom/media/test/mochitest_background_video.toml', 'dom/media/test/mochitest_bugs.toml', 'dom/media/test/mochitest_stream.toml'])

  Make sure the test paths (if any) are spelt correctly and the corresponding
  --flavor and --subsuite are being used. See mach mochitest --help for a
  list of valid flavors.

  • 4 of 4 failed on the same (retriggered) task
    - test-windows11-64-2009-qr/opt-mochitest-media-wmfme (fu8WxJ7PSmC7CkS0C8v5jQ)
    - test-windows11-64-2009-qr/opt-mochitest-media-wmfme (IFTkz-QeTMWLpl8Wa1hKWQ)
    - test-windows11-64-2009-qr/opt-mochitest-media-wmfme (BauRMzhCRBmbgazRMuxOJQ)
    - test-windows11-64-2009-qr/opt-mochitest-media-wmfme (K8xGlcJ3SeWmBBpimrx4nw)

Needs Investigation (Possible Intermittents):

• browser/base/content/test/tabs/browser_lastSeenActive.js
  • 1 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-6 (dsddaFyyS4maBjoZNtJRjA)
• test-android-em-7.0-x86_64-qr/opt-geckoview-junit-fis - 1 of 4 failed on the same (retriggered) task (failed: QZP3CQ8bSUO140nd82paUg)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor media/libopus/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).