1892772 - "welcome-text" container is still rendered in the absence of title and subtitle

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Jason Prickett]

Attachment: Screenshot 2024-04-22 at 10.02.54 AM.png

When both a title and subtitle aren't included in a screen's content in the split layout for spotlight, the element that contains them is still rendered, which makes the flex layout behave strangely when there is no title or subtitle.

Comment 1

[Jason Prickett]

[Tracking Requested - why for this release]:
Necessary to run Embedded Migration wizard spotlight experiment in 126

Comment 2

[Donal Meehan [:dmeehan]]

Tracking as requested.
Please keep in mind that next week is the final week of beta for Fx126.
Patches need to land in central and have a beta uplift request between now and EOD 2024-05-02

Comment 3

[Jason Prickett]

Attachment: Bug 1892772 - Prevent about welcome split title container from rendering when no title or subtitle is present r?#omc-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cad50dfead95
Prevent about welcome split title container from rendering when no title or subtitle is present r=omc-reviewers,aminomancer

Comment 5

[Cristian Tuns]

Backed out for causing node newtab failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | bundles | about:welcome bundle out of date

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7b12d1b9f0f
Prevent about welcome split title container from rendering when no title or subtitle is present r=omc-reviewers,aminomancer

Comment 7

[Jason Prickett]

Attachment: Bug 1892772 - Prevent about welcome split title container from rendering when no title or subtitle is present r?#omc-reviewers

Original Revision: https://phabricator.services.mozilla.com/D208269

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e7b12d1b9f0f

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: n/a, experiment will not run in 126
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps are present in this patch
• Risk associated with taking this patch: minimal
• Explanation of risk level: This prevents an element from rendering when it is empty. All of the current use cases have this element with children it, so this code will not affect them.
• String changes made/needed: None
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/31ee47c3ca42